Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on windows #1111

Closed
wants to merge 11 commits into from
Closed

Conversation

webmaster128
Copy link
Member

This is a follow-up of #1110 (merge that first, then rebase this PR). The main point here is that we are running wasmd unit-tests on Windows. This works more or less. But a lot of tests are failing.

A lot of failures look something like this:

testing.go:1097: TempDir RemoveAll cleanup: remove C:\Users\CIRCLE~1.PAC\AppData\Local\Temp\TestPinPong2683230876\001\data\snapshots\metadata.db\000001.log: The process cannot access the file because it is being used by another process.

I don't know how this happens. Maybe the app needs to be shut down before nodeHome := t.TempDir() is deleted or something like this.

Any help would be appreciated.

@alpe
Copy link
Member

alpe commented Nov 29, 2022

This looks familiar. The DB on the IBC tests may need to be closed. I will 👁️ at this when I get a chance

@alpe
Copy link
Member

alpe commented Nov 29, 2022

I pushed a quick shot to close the test DBs. 🤞
This was intended on a new branch but I misstyped the push. Sorry for this

@webmaster128
Copy link
Member Author

This was intended on a new branch but I misstyped the push. Sorry for this

No worries. Happy to share this one to fix wasmd unit tests on Windows. We'll need to clean up here anyways after #1110 is in.

@webmaster128
Copy link
Member Author

Thank you @alpe, that's very helpful. Don't worry about the remaining issues, especially the crashes. There is something fishy going on in wasmvm. I'm on it.

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alpe
Copy link
Member

alpe commented Mar 22, 2023

This PR is blocked on CosmWasm/wasmvm#389

@webmaster128 webmaster128 deleted the run-unit-tests-on-windows branch March 22, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants