#151 make minter optional

[taitruong]

PR for #151

Rather prefer having minter: Option<String>:

cw-nfts/contracts/cw721-base/src/msg.rs

Lines 8 to 18 in 177a993

	pub struct InstantiateMsg {
	/// Name of the NFT contract
	pub name: String,
	/// Symbol of the NFT contract
	pub symbol: String,
	/// The minter is the only one who can create new NFTs.
	/// This is designed for a base NFT that is controlled by an external program
	/// or contract. You will likely replace this with custom logic in custom NFTs
	pub minter: String,
	}

In case of none, info.sender should be minter. Makes it easier for other contracts (e.g. minter) re-using this msg.

In most cases creator of contract is also minter. Rn creator (=sender) instantiates contract AND need to provides its own address in minter prop. You can see this in unit tests:

Before: duplicate, since creator is in info.sender and minter.prop

        let info = mock_info(CREATOR, &[]);
        let init_msg = InstantiateMsg {
            name: "SpaceShips".to_string(),
            symbol: "SPACE".to_string(),
            minter: CREATOR.to_string(),
            withdraw_address: None,
        };
        entry::instantiate(deps.as_mut(), mock_env(), info.clone(), init_msg).unwrap();

After: no need to provider minter prop, since creator is sender:

        let info = mock_info(CREATOR, &[]);
        let init_msg = InstantiateMsg {
            name: "SpaceShips".to_string(),
            symbol: "SPACE".to_string(),
            minter: None,
            withdraw_address: None,
        };
        entry::instantiate(deps.as_mut(), mock_env(), info.clone(), init_msg).unwrap();

Instantiation is like this then:

like before, in case caller should NOT be minter/owner (edge case):

{"name": "foo", "symbol": "bar", "minter": "other_than_caller"}

for creator (standard, 99.99% case):

{"name": "foo", "symbol": "bar"}

@shanev @JakeHartnell

[taitruong]

You can also see from adjusted tests - it looks more convenient and natural.

[taitruong]

If you scroll up, in line 135, you can see CREATOR is the sender

[taitruong]

Reason, why I came to this conclusion is this here: https://github.com/public-awesome/launchpad/blob/main/contracts/collections/sg721-base/src/contract.rs#L53-L58

        // cw721 instantiation
        let info = CW721ContractInfoResponse {
            name: msg.name,
            symbol: msg.symbol,
        };
        self.parent.contract_info.save(deps.storage, &info)?;
        cw_ownable::initialize_owner(deps.storage, deps.api, Some(&msg.minter))?;

All this logic can completely be removed, by calling parent.instantiate. Also these 3 props can be replaced by cw721_base::msg::InstantiateMsg: https://github.com/public-awesome/launchpad/blob/main/packages/sg721/src/lib.rs#L118-L120

pub struct InstantiateMsg {
    pub name: String,
    pub symbol: String,
    pub minter: String,
    pub collection_info: CollectionInfo<RoyaltyInfoResponse>,
}

@jhernandezb

[JakeHartnell]

I'm fine with this, curious what others thinks, but agree it would be slightly nicer.

[taitruong]

@shanev need one more approval, then we can merge and release 0.19.0 (#150)

[shanev]

Good change :)