Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using new cosmwasm_schema #102

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Using new cosmwasm_schema #102

merged 7 commits into from
Nov 30, 2022

Conversation

peara
Copy link
Contributor

@peara peara commented Nov 24, 2022

I try to implement what's in #81.
Remaining issues:

  • In cw2981-royalites, QueryMsg<Cw2981QueryMsg> is used. As in cw721-base generates an empty response for Extension, there is no response generated for Cw2981QueryMsg. I haven't found a solution for this.
  • In cw721-non-transferable, most of QueryMsg enums are redefined. I want a more robust solution than copy lines from cw721-base.

@peara
Copy link
Contributor Author

peara commented Nov 28, 2022

@shanev @larry0x
Can you help me check why circle ci didn't run?

JakeHartnell
JakeHartnell previously approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. CI does appear to be stuck though. @ueco-jb anyway to reset?

larry0x
larry0x previously approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@larry0x larry0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one suggested change

contracts/cw721-fixed-price/src/msg.rs Outdated Show resolved Hide resolved
@JakeHartnell @larry0x
Update contracts/cw721-fixed-price/src/msg.rs
e376e61 
Co-authored-by: Larry Engineer <26318510+larry0x@users.noreply.github.com>
@JakeHartnell JakeHartnell dismissed stale reviews from larry0x and themself via e376e61 November 29, 2022 00:07
@webmaster128 webmaster128 reopened this Nov 29, 2022
@webmaster128
Copy link
Member

For some strange reason, no CircleCI build is started. I don't know why. I'll set a reminder to check again tomorrow.

@webmaster128
Copy link
Member

We are getting builds now :)

@peara
Copy link
Contributor Author

peara commented Nov 29, 2022

It was because I asked Circle ci to check my fork... really sad!

@webmaster128
Copy link
Member

Strange because fork builds are enabled and they worked for other PRs here before. I see the build in https://app.circleci.com/pipelines/github/CosmWasm/cw-nfts now.

@larry0x larry0x self-requested a review November 29, 2022 16:38
larry0x
larry0x previously approved these changes Nov 29, 2022
View reviewed changes
contracts/cw721-base/src/msg.rs Outdated Show resolved Hide resolved
@peara @larry0x
Update contracts/cw721-base/src/msg.rs
6f54d68 
Co-authored-by: Larry Engineer <26318510+larry0x@users.noreply.github.com>
@peara
Copy link
Contributor Author

peara commented Nov 29, 2022

Strange because fork builds are enabled and they worked for other PRs here before. I see the build in https://app.circleci.com/pipelines/github/CosmWasm/cw-nfts now.

Before submitting this PR, I enabled CircleCI on my own fork and that blocked it from running it here.

@larry0x larry0x self-requested a review November 29, 2022 16:53
@JakeHartnell JakeHartnell merged commit 3481273 into CosmWasm:main Nov 30, 2022
@peara peara deleted the new-schema branch November 30, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@larry0x larry0x larry0x approved these changes

@0xekez 0xekez Awaiting requested review from 0xekez

@shanev shanev Awaiting requested review from shanev

@yubrew yubrew Awaiting requested review from yubrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peara @webmaster128 @JakeHartnell @larry0x