Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make minter for instantiate msg optional #151

Open
taitruong opened this issue Jan 10, 2024 · 0 comments
Open

make minter for instantiate msg optional #151

taitruong opened this issue Jan 10, 2024 · 0 comments

Comments

@taitruong
Copy link
Collaborator

taitruong commented Jan 10, 2024

Rather prefer having minter: Option<String>:

pub struct InstantiateMsg {
/// Name of the NFT contract
pub name: String,
/// Symbol of the NFT contract
pub symbol: String,
/// The minter is the only one who can create new NFTs.
/// This is designed for a base NFT that is controlled by an external program
/// or contract. You will likely replace this with custom logic in custom NFTs
pub minter: String,
}

In case of none, info.sender should be minter. Makes it easier for other contracts (e.g. minter) re-using this msg.

taitruong added a commit to arkprotocol/cw-nfts that referenced this issue Jan 10, 2024
shanev added a commit that referenced this issue Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant