Provide MessagePack serialization #2118
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
cosmwasm_core::{Binary, HexBinary}
to (de)serialize directly as binary blobs when used together with a compact encoding (meaning one that returnsfalse
fromis_human_readable
), andcosmwasm_std::{from_msgpack, to_msgpack_vec, to_msgpack_binary}
.Breakage
If we're being rigorous, I think the changes tocosmwasm_core::{Binary, HexBinary}
are breaking if used for storage with a binary encoding. Maybe we should release this with a major version bump or deprecate these types in favor of some new ones. @webmaster128 you're the decision-maker here.This is breaking if we assume someone out there has used the binary/checksum types with binary encodings.
We're not bumping the major version for this since as far as we're concerned, that use case has always been unsupported. Still, we're going to release this with a minor version bump, and before it's released we're going to provide some "guard rails" via #2125, #2126, #2127.
TODO