new cosmwasm doc #1968

costa2400 · 2023-12-05T19:15:20Z

No description provided.

webmaster128

Thank you!

I think Chris can review the changes when he's back. In the meantime could you run the markdown formatter we use here? ./devtools/format_md.sh This should make the CI happy and makes it easier to review the changes.

webmaster128 · 2023-12-06T09:08:48Z

Also check out https://editorconfig.org/ and cargo fmt for some of the complains from the CI

chipshort

Nice stuff! This adds doc comments to a lot of types that were missing them.
I left some comments inline to improve.
It would also be good to add the leading space to all of the doc-comments. A lot of the new / changed ones are missing it.

docs/CAPABILITIES.md

docs/STORAGE_KEYS.md

chipshort · 2024-01-10T11:40:26Z

packages/std/src/deps.rs

@@ -15,13 +15,13 @@ pub struct OwnedDeps<S: Storage, A: Api, Q: Querier, C: CustomQuery = Empty> {
    pub querier: Q,
    pub custom_query_type: PhantomData<C>,
 }
-
+/// A mutable version of `Deps` that allows changes to the dependencies.


Nice to have a doc comment here. I think we can be a bit more specific:

Suggested change

/// A mutable version of `Deps` that allows changes to the dependencies.

/// A mutable version of `Deps` that allows writing to storage.

packages/std/src/errors/std_error.rs

packages/std/src/results/events.rs

packages/std/src/results/submessages.rs

packages/std/src/types.rs

packages/std/src/errors/std_error.rs

Co-authored-by: Christoph Otter <chipshort@tutanota.com>

costa2400 added 3 commits December 5, 2023 14:14

storage key changes

6417d7f

cw struct comments

d8ee801

capabilities edit

f13ec9c

costa2400 changed the title ~~storage key changes~~ new cosmwasm doc Dec 5, 2023

costa2400 requested a review from chipshort December 5, 2023 21:29

webmaster128 reviewed Dec 6, 2023

View reviewed changes

costa2400 added 3 commits December 8, 2023 19:32

cargo fmt

195b242

enum comments

70a388a

Update std_error.rs

04933f0

costa2400 requested a review from hashedone December 12, 2023 21:49

chipshort reviewed Jan 10, 2024

View reviewed changes

costa2400 and others added 3 commits January 11, 2024 16:15

Update docs/STORAGE_KEYS.md

4832805

Co-authored-by: Christoph Otter <chipshort@tutanota.com>

Update docs/CAPABILITIES.md

fb02d73

Co-authored-by: Christoph Otter <chipshort@tutanota.com>

Update packages/std/src/errors/std_error.rs

32b9852

Co-authored-by: Christoph Otter <chipshort@tutanota.com>

costa2400 enabled auto-merge January 11, 2024 21:16

costa2400 closed this Jan 11, 2024

auto-merge was automatically disabled January 11, 2024 21:16
Pull request was closed

costa2400 reopened this Jan 16, 2024

costa2400 added 2 commits January 23, 2024 11:00

doc edit

00b2b16

merge: branch 'main' of https://github.com/costa2400/cosmwasm

137f6d3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new cosmwasm doc #1968

new cosmwasm doc #1968

costa2400 commented Dec 5, 2023

webmaster128 left a comment

webmaster128 commented Dec 6, 2023

chipshort left a comment

chipshort Jan 10, 2024

	/// A mutable version of `Deps` that allows changes to the dependencies.
	/// A mutable version of `Deps` that allows writing to storage.

new cosmwasm doc #1968

Are you sure you want to change the base?

new cosmwasm doc #1968

Conversation

costa2400 commented Dec 5, 2023

webmaster128 left a comment

Choose a reason for hiding this comment

webmaster128 commented Dec 6, 2023

chipshort left a comment

Choose a reason for hiding this comment

chipshort Jan 10, 2024

Choose a reason for hiding this comment