Add set_wasm_version! to create custom Wasm section #1946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
reviewed
Nov 14, 2023
Comment on lines
+10
to
+12
| #[link_section = "cw5"] | ||
| #[allow(unused)] | ||
| static AS_BYTES: [u8; FULL.len()] = const_str::to_byte_array!(FULL); |
There was a problem hiding this comment.
As simple as that. I like it.
There was a problem hiding this comment.
The #[used] attribute can also be useful, to prevent this from disappearing after optimisation: https://doc.rust-lang.org/beta/reference/abi.html#the-used-attribute
There was a problem hiding this comment.
It's not removed in the custom Wasm section in any case. I guess link_section ensures that. Other than that in the Wasm program it is not needed to have a static address. So I'm happy if it's optimized out.
|
This should become a crate in cw-minus (soon a workspace hosting cw-utils, cw2 and other libraries for contract development) |
|
Done in #2124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early PoC. Should not be maintained here long term.