Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage level restarts on very_old_saves #2518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lewri
Copy link
Member

@lewri lewri commented Mar 6, 2024

Proposal to give the option to the user to restart their level for very old saves compared to just information.
This method might be too assertive on the player so it can be dropped if it's going to be too far.

Describe what the proposed change does

  • Changes this UIInformation to a UIConfirmDIalog for old saves.
  • Adapts App:restart() to take an optional message for the box

image

@lewri
Copy link
Member Author

lewri commented Mar 6, 2024

If we wanted to go ahead then I can ask our translators for strings if needed as this is an important message.

@TheCycoONE
Copy link
Member

Good idea. I would leave off the first "this level"

A few comments:
new-20 is a bit arbitrary, sometimes we'd eat through more than that in a single version, maybe we can do something with the release table we're maintaining in TheApp (currently a giant if condition).

I'm not sure this shouldn't be built into the existing TheApp.checkCompatibilty handling (see that function and peristence.lua where it's called)

@lewri
Copy link
Member Author

lewri commented Mar 7, 2024

new-20 is a bit arbitrary, sometimes we'd eat through more than that in a single version, maybe we can do something with the release table we're maintaining in TheApp (currently a giant if condition).

Struggling with ideas on this one currently. Really for a good flexible comparison the function needs to be redesigned in a way that reports a better testable case so handle e.g. current release - 2. Generally speaking, that means we flag for 0.65 being loaded in 0.68 and so on. But say we skipped to 0.70 this release, then it still needs to flag against 0.65 rather than 0.67
(Then we also need to decide what to do with Trunk)

@lewri lewri changed the title Encourage level restarts on very_old_saves [WIP] Encourage level restarts on very_old_saves Mar 7, 2024
@lewri
Copy link
Member Author

lewri commented Mar 13, 2024

Good idea. I would leave off the first "this level"

A few comments: new-20 is a bit arbitrary, sometimes we'd eat through more than that in a single version, maybe we can do something with the release table we're maintaining in TheApp (currently a giant if condition).

I'm not sure this shouldn't be built into the existing TheApp.checkCompatibilty handling (see that function and peristence.lua where it's called)

Pushed the string change for now.
In regards to versions I've started #2527 as my planned changes will probably deserve their own PR separate to this. If you want to hold back the PR still until that's done that's fine.

@lewri lewri changed the title [WIP] Encourage level restarts on very_old_saves Encourage level restarts on very_old_saves Mar 13, 2024
Changes this UIInformation to a UIConfirmDIalog for old saves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants