Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Set volume straight after music is set playing #2089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mugmuggy
Copy link
Contributor

@mugmuggy mugmuggy commented Jan 7, 2022

Fixes #1978

Describe what the proposed change does

  • Sets the volume after starting playing the track - SDL2_mixers midi volume function on windows uses a handle to the stream to set the volume which requires that Mix_PlayMusic is called to open that handle initially.

@lewri
Copy link
Member

lewri commented Jan 8, 2022

It looks like this fixes the first song playback. Unfortunately, however it isn't sent until music is played.
The volume of the opening music is still stuck sadly until you get to main menu (looks like video still not sending SDL volume update)

@mugmuggy
Copy link
Contributor Author

mugmuggy commented Jan 9, 2022

I think we'd need a fix for 524 to actually get that to happen. Windows is remembering the last volume set, which due to 524 is the volume of the music in game from the last time its run. What you really need is that full system volume range is used and then the ratios apply. I have a hacky patch in mind for sdl2_mixer for the 524 issue, I just need to see how it integrates with the full behaviour once integrated.

Copy link
Member

@lewri lewri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to proceed with this, but should probably make a new issue (or adjust 524) about the specific intro video bug.

@lewri lewri added this to In progress in 0.66 Release via automation Jan 22, 2022
@lewri lewri moved this from In progress to Missed/Postponed in 0.66 Release May 21, 2022
@lewri lewri added this to In progress in 0.67 Release via automation May 21, 2022
@lewri lewri moved this from In progress to Missed/Postponed in 0.67 Release Jul 1, 2023
@lewri lewri added this to In progress in 0.68 Release Jul 1, 2023
@lewri
Copy link
Member

lewri commented Aug 24, 2023

@mugmuggy do you know if our changes to SDL2/Fluidsynth for Windows in 0.67 still require this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
0.68 Release
  
In progress
0.66 Release
  
Missed/Postponed
0.67 Release
  
Missed/Postponed
Development

Successfully merging this pull request may close these issues.

[Bug] CorsixTH does not obey config volume settings
2 participants