Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added R CMD CHECK #43

Merged
merged 2 commits into from
Apr 6, 2023
Merged

added R CMD CHECK #43

merged 2 commits into from
Apr 6, 2023

Conversation

tuhinmallick
Copy link
Collaborator

No description provided.

@KonradUdoHannes
Copy link
Collaborator

@tuhinmallick Thanks for including the actions. I think they still have a setup issue specific to our client and our tests. Our client always needs the metabase url, user and password to initialize properly. The tests don't actually require these values, as they use pre-recorded requests with vcr. Nonetheless the values need to be set for a client to initialize. This means we should be able to set the parameters to fake values, to allow client initialization. I think the best way is probably to set environment variables in the workflows themselves.

If you want to try this let me know. Otherwise I can also take over.

Copy link
Collaborator

@KonradUdoHannes KonradUdoHannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the added env variables all works out.

@KonradUdoHannes KonradUdoHannes merged commit ddf72aa into main Apr 6, 2023
5 checks passed
@KonradUdoHannes KonradUdoHannes deleted the feature/rmccheck_actions branch April 6, 2023 18:49
@KonradUdoHannes KonradUdoHannes mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants