Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added badges #37

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Added badges #37

merged 3 commits into from
Mar 21, 2023

Conversation

tuhinmallick
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@KonradUdoHannes KonradUdoHannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍.
There is still some trouble with the licence badge, both for the badge itself, as well as for the link. I'm not entirely sure what to do. I think the issue comes from the two licence files LICENCE and LICENCE.md at the same time. I looked at big R packages on github which have the same file structure and so far I did not find one that used a licence Badge. So I'm wondering whether we should also just remove that badge for an R project.

@tuhinmallick
Copy link
Collaborator Author

@KonradUdoHannes Corrected

@KonradUdoHannes
Copy link
Collaborator

@tuhinmallick Thanks for fixing the link, but I'm still unsure whether we should leave the licence Badge because it does not look so good that it is not working (i.e. doesn't get a specific licence name for the badge). And as I mentioned big R projects also don't seem to solve this and simply omit a licence badge.

Copy link
Collaborator

@KonradUdoHannes KonradUdoHannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KonradUdoHannes KonradUdoHannes merged commit a81a80c into main Mar 21, 2023
@KonradUdoHannes KonradUdoHannes deleted the documentation/readme branch April 6, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants