Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basque localisation #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

xabirequejo
Copy link

Hi,
I believe I have translated all the files and most of the strings for Buran to be usable in Basque.
It would be great if Basque locale was added to Buran in a future update.
Thanks

@Corewala
Copy link
Owner

Hi, this is really amazing work, thank you so much! I noticed that "show_inline_images" and "pkcs_notice" aren't translated yet, but other than that everything looks good! Since I'm going to work on a couple other bugfixes before the next release, I'll keep this PR open for now, but I'll definitely merge it before v1.13!

@Corewala
Copy link
Owner

Because of df6c159 you don't need to translate "load_image" since it isn't used anywhere.

@xabirequejo
Copy link
Author

xabirequejo commented Feb 20, 2023

Truth is I have no idea how to translate pkcs_notice so I thought leaving it as is was the better option.
I'll edit the file to include inline_images and remove load_image.

Could PKCS12 client keystores be translated as ≈ password wallets or managers?

- 'load_image' has been removed
- 'inline_icons' & 'inline_images' have been translated
- 'pkcs_notice' might be translated
- small fixes
@Corewala
Copy link
Owner

Could PKCS12 client keystores be translated as ≈ password wallets or managers?

Honestly I was considering changing the wording for that string since elsewhere they're called "client certificates." Would "Only PKCS12 certificate files are currently supported" be easier to translate?

@xabirequejo
Copy link
Author

Yes, that would make it a lot easier. So long as it's still accurate.
≈ PKCS12 ziurtagiri-fitxategiak soilik erabil daitezke oraingoz.

@Corewala
Copy link
Owner

Yes, that should be accurate, and honestly probably more informative than "client keystores."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants