fix reading comment from excel file #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
requested changes
Nov 19, 2023
| } | ||
|
|
||
| public struct Text: Codable, Equatable { | ||
| public let plain: String? |
There was a problem hiding this comment.
Unfortunately, breaking API is not something we can merge. Could you re-introduce plain here?
| @@ -36,12 +36,25 @@ public struct Comment: Codable, Equatable { | |||
| case reference = "ref" | |||
| case text | |||
| } | |||
|
|
|||
| public var plain: String? { | |||
| return self.text.r?.t | |||
There was a problem hiding this comment.
Given the comment on plain:
Suggested change
| return self.text.r?.t | |
| return self.text.r?.t ?? self.text.plain |
|
Please tag me as a reviewer, so that I see the open PR pop up. You can re-request usig the icon next to my name under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.