New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unlimitedStorage to ext manifest #906
base: 3.X.X-Branch
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## 3.X.X-Branch #906 +/- ##
=============================================
Coverage 49.87% 49.87%
=============================================
Files 31 31
Lines 2476 2476
Branches 740 740
=============================================
Hits 1235 1235
Misses 1240 1240
Partials 1 1 Continue to review full report at Codecov.
|
Signed-off-by: Kenneth Tran <kennethtran93@users.noreply.github.com>
60ef93b
to
3409711
Compare
Pull Request Build: 277401588
Unsigned webextension builds for testing is ready for download! Generating Download Links
When new command comment is posted, please allow a few seconds for the command to be received and processed.
Due to API limitations, generated links will only be valid for one minute! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably wait until there is an actual code that uses this permission
That is true. Note that storage.local only allows ~5 MB (5,242,880 bytes). While my current lists amount to just over 25kb, others may have more, especially if they have heavily configured it (e.g. those what do both the main domain and the wildcard subdomains at the same time) and/or have a rather large activity log (though we do truncate it to the last 10 entries). In addition, Chrome has that hard limit, but Firefox has yet to cap it yet. This may probably come into effect if I were to try and implement a history/internal backup function through a combination of storage.local and storage.sync (both browsers have a hard limit of ~100 kB (102,400 bytes) and cannot be increased through unlimitedStorage). |
2e1ae20
to
659f46d
Compare
a918935
to
25332a1
Compare
For the future.
This will also pave the way for some form of browser sync.
Signed-off-by: Kenneth Tran kennethtran93@users.noreply.github.com