Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unlimitedStorage to ext manifest #906

Draft
wants to merge 1 commit into
base: 3.X.X-Branch
Choose a base branch
from

Conversation

kennethtran93
Copy link
Member

For the future.

This will also pave the way for some form of browser sync.

Signed-off-by: Kenneth Tran kennethtran93@users.noreply.github.com

@kennethtran93 kennethtran93 self-assigned this Sep 26, 2020
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #906 into 3.X.X-Branch will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.X.X-Branch     #906   +/-   ##
=============================================
  Coverage         49.87%   49.87%           
=============================================
  Files                31       31           
  Lines              2476     2476           
  Branches            740      740           
=============================================
  Hits               1235     1235           
  Misses             1240     1240           
  Partials              1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4165def...3409711. Read the comment docs.

Signed-off-by: Kenneth Tran <kennethtran93@users.noreply.github.com>
@github-actions
Copy link

Pull Request Build: 277401588

Unsigned webextension builds for testing is ready for download!
These test builds are only kept for up to 90 days from the date of this post.
It is strongly recommended to use a fresh profile for testing these builds to prevent any kind of modifications to existing data.

Generating Download Links

  • /get-build for the latest commit build.
  • /get-build 277401588 for this specific commit 3409711 build.

When new command comment is posted, please allow a few seconds for the command to be received and processed.

  • 👀 indicates that command has been received.
  • 🚀 indicates that command has been sent for further processing.
  • 🎉 indicates that command has been executed. Expect a new comment with the result shortly.

Due to API limitations, generated links will only be valid for one minute!

Copy link
Member

@ke-d ke-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably wait until there is an actual code that uses this permission

@kennethtran93
Copy link
Member Author

We should probably wait until there is an actual code that uses this permission

That is true. Note that storage.local only allows ~5 MB (5,242,880 bytes). While my current lists amount to just over 25kb, others may have more, especially if they have heavily configured it (e.g. those what do both the main domain and the wildcard subdomains at the same time) and/or have a rather large activity log (though we do truncate it to the last 10 entries). In addition, Chrome has that hard limit, but Firefox has yet to cap it yet.

This may probably come into effect if I were to try and implement a history/internal backup function through a combination of storage.local and storage.sync (both browsers have a hard limit of ~100 kB (102,400 bytes) and cannot be increased through unlimitedStorage).

@kennethtran93 kennethtran93 marked this pull request as draft September 29, 2020 06:30
@kennethtran93 kennethtran93 force-pushed the 3.X.X-Branch branch 4 times, most recently from 2e1ae20 to 659f46d Compare July 18, 2022 02:26
@kennethtran93 kennethtran93 force-pushed the 3.X.X-Branch branch 3 times, most recently from a918935 to 25332a1 Compare November 15, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants