New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another round of trying to get IPv6 to work. #1498
base: 3.X.X-Branch
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## 3.X.X-Branch #1498 +/- ##
================================================
+ Coverage 47.90% 48.16% +0.25%
================================================
Files 34 34
Lines 2749 2755 +6
Branches 835 841 +6
================================================
+ Hits 1317 1327 +10
+ Misses 1431 1427 -4
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…arser. Keep existing expression id. Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
441deea
to
28082a5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Pull Request Build: 4395017421
Unsigned webextension builds for testing is ready for download! Clickable Download Links (BETA)NOTE: Ensure you are already signed into GitHub before clicking on the links below.
Please note that if the link(s) above returns a 404 Not Found, you may not be signed into GitHub, or it may have expired and/or manually removed before expiry date. This post does not get updated if artifacts are removed. Try the alternate method below if the link(s) above do not work. To Generate Download Links (Alternate Method if above links do not work for some reason)
When new command comment is posted, please allow a few seconds for the command to be received and processed.
Due to API limitations, generated links from the alternate method will only be valid for one minute! |
Only remove IPv6 square brackets when putting it through the ipaddr parser.
Also on expression updates, keep existing expression id.
Fixes #983 (again, hopefully).