Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another round of trying to get IPv6 to work. #1498

Open
wants to merge 2 commits into
base: 3.X.X-Branch
Choose a base branch
from

Conversation

kennethtran93
Copy link
Member

Only remove IPv6 square brackets when putting it through the ipaddr parser.

Also on expression updates, keep existing expression id.

Fixes #983 (again, hopefully).

@kennethtran93 kennethtran93 added the bugfix Pull Requests that fixes a bug raised from an issue. label Mar 12, 2023
@kennethtran93 kennethtran93 self-assigned this Mar 12, 2023
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #1498 (28082a5) into 3.X.X-Branch (e89a46c) will increase coverage by 0.25%.
The diff coverage is 77.04%.

@@               Coverage Diff                @@
##           3.X.X-Branch    #1498      +/-   ##
================================================
+ Coverage         47.90%   48.16%   +0.25%     
================================================
  Files                34       34              
  Lines              2749     2755       +6     
  Branches            835      841       +6     
================================================
+ Hits               1317     1327      +10     
+ Misses             1431     1427       -4     
  Partials              1        1              
Impacted Files Coverage Δ
src/background.ts 0.00% <ø> (ø)
src/ui/common_components/ExpressionOptions.tsx 0.00% <0.00%> (ø)
src/ui/settings/components/Expressions.tsx 0.00% <0.00%> (ø)
src/redux/Reducers.ts 100.00% <100.00%> (ø)
src/services/CleanupService.ts 100.00% <100.00%> (ø)
src/services/Libs.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…arser. Keep existing expression id.

Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
Signed-off-by: Kenneth T <6724477+kennethtran93@users.noreply.github.com>
@github-actions

This comment was marked as outdated.

@github-actions
Copy link

Pull Request Build: 4395017421

Unsigned webextension builds for testing is ready for download!
These test builds are only kept for up to 90 days from the date of this post.
It is strongly recommended to use a fresh profile for testing these builds to prevent any kind of modifications to existing data.

Clickable Download Links (BETA)

NOTE: Ensure you are already signed into GitHub before clicking on the links below.

Filename Created Timestamp Expiry Timestamp
Cookie-AutoDelete_Dev_20230312_010540_28082a5_Chrome 2023-03-12 @ 01:05:53Z UTC 2023-06-10 @ 01:05:46Z UTC
Cookie-AutoDelete_Dev_20230312_010540_28082a5_Firefox 2023-03-12 @ 01:05:53Z UTC 2023-06-10 @ 01:05:44Z UTC

Please note that if the link(s) above returns a 404 Not Found, you may not be signed into GitHub, or it may have expired and/or manually removed before expiry date. This post does not get updated if artifacts are removed. Try the alternate method below if the link(s) above do not work.

To Generate Download Links (Alternate Method if above links do not work for some reason)

  • /get-build for the latest commit build.
  • get-build 4395017421 for this specific commit 28082a5 build.

When new command comment is posted, please allow a few seconds for the command to be received and processed.

  • 👀 indicates that command has been received.
  • 🚀 indicates that command has been sent for further processing.
  • 🎉 indicates that command has been executed. Expect a new comment with the result shortly.

Due to API limitations, generated links from the alternate method will only be valid for one minute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull Requests that fixes a bug raised from an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "Type error for parameter options" notification when clearing data of IPv6 sites
1 participant