[BUG] "Type error for parameter options" notification when clearing data of IPv6 sites #983

wodim · 2020-12-02T13:07:26Z

Similar to #482. It happens when I try to clear cookies/storage/etc. of an ipv6 site that I've accessed directly by its ip address.

CAD 3.5.1 running on Firefox 83.0 on Windows 10.

wodim · 2020-12-02T13:42:33Z

That's what I get when I clear by hand using the toolbar button. I have autoclear on and, when I close the tab, instead I get:

kennethtran93 · 2020-12-02T21:36:31Z

Did it happen before on previous versions of firefox?

wodim · 2020-12-02T22:06:42Z

I don't know, I just switched to Firefox.

kennethtran93 · 2020-12-03T01:26:02Z

Is there an IPv6 url that you can provide to me that creates cookies and possibly other site data? I haven't used any direct access via IPv6 before.

wodim · 2020-12-03T09:54:13Z

The error can be reproduced even if the site does not set cookies or local storage.

http://[2602:806:a003:40e:b1be:7700:1:1]/

kennethtran93 · 2020-12-03T23:02:37Z

Took me a while to realize that my cable provider's router does not yet support IPv6 addresses, as I was wondering why IPv6 addresses weren't being found. This will take me a while to troubleshoot. Sorry.

kennethtran93 · 2021-03-03T05:38:47Z

Just a minor update - I haven't had time to setup an IPv6 tunnel broker on my router yet. I'm hoping that once I do set this up I can view IPv6 addresses. Just need to free up some some time outside of work in order to do this, as well as minimize disruption to my network.

stripwire · 2021-05-28T13:40:54Z

You can test this with localhost ipv6 (::1), or use alternative ipv6 network "yggdrasil".

ProactiveServices · 2021-06-24T17:34:02Z

Seems other cookie management add-ons have the same problem. Here's a workaround: but take a backup of your Firefox profile first. The CookieBro add-on also can't remove them, but it lets you import/export cookies to a file. You can then edit the file and manually remove the offending cookies, have Firefox clear all cookies, then import the edited file.

t-makaro · 2021-08-02T06:02:20Z

I encountered this error when going to my router with its link-local IPv6 address.

tsmithe · 2022-01-17T19:27:48Z

I have started accessing more IPv6 pages and am also hitting this now.

jgoerzen · 2022-01-18T14:07:53Z

I am also seeing this. It only started when using ipv6 IPs in URLs. These are common, for instance, on the Yggdrasil Network https://yggdrasil-network.github.io/

ddvarpdd · 2022-02-09T15:26:40Z

Same problem can be observed in Cookie Quick Manager (ysard/cookie-quick-manager#130), so it seems like it's an upstream issue with Firefox. This bug might be related to that.

suhr · 2022-04-06T13:58:10Z

Is there a way to workaround this? Now I see this every time I close a tab. It's rather annoying.

UPDATE: manually removing ipv6 cookies in the settings helps.

jthat · 2022-05-24T01:30:57Z

I've also been experiencing this for a while now.

@kennethtran93 I wonder if the workaround described by @Rob--W (in the Firefox bug @ddvarpdd referred to) could be worth trying. I'm not familiar with the code, but it does seem like we may be doing what it describes, and perhaps replacing : with + in firstPartyDomain might make it work?

Antorell · 2022-08-24T21:54:49Z

Same issue here for IndexedDB. It seems Cookie Autodelete fails because it tries to delete cookies from a plain IPV6 address when in Firefox's storage the ipv6 ip is saved in storage with the brackets [ ] of the url.

Also, for me when I try to clean cookies only it shows a pop-up saying it deleted the cookie when in reality the app didn't delete anything. If I do the same on the ipv4 of my server, the app deletes the cookies right away.

This is taken from Firefox's cookies storage:

Created:"Wed, 24 Aug 2022 21:36:36 GMT"
Domain:"[9009:999:9999:999:b00b:f001::]"
Expires / Max-Age:"Session"  
HostOnly:true
HttpOnly:false
Last Accessed:"Wed, 24 Aug 2022 21:44:24 GMT"
SameSite:"Lax"

Rob--W · 2022-09-04T09:56:32Z

I looked into this report to determine whether there is a bug in the browser or extension. It looks like there is a bug in the CAD extension.

I tried to reproduce as follows:

Start a server at localhost at port 1234 (listening on IPv6 loopback address)
Install CAD
Visit http://[::1]:1234/
Click the extension button, Clean, "Clean Service Workers for this Domain"
Result: notification like the error at [BUG] "Type error for parameter options" notification when clearing data of IPv6 sites #983 (comment)

When I step through with a debugger, I can observe that CAD is trying to call browsingData.remove with hostnames: ["::1", ".::1", "www.::1", ".www.::1]. These are clearly invalid domain names. The root cause of the issue is that the logic responsible for generating the hosts to clean does NOT account for IPv6 domains (nor IPv4):

Cookie-AutoDelete/src/services/Libs.ts

Lines 679 to 714 in 659f46d

    
           /** 
        
            * Prepare Domains for all cleanups. 
        
            */ 
        
           export const prepareCleanupDomains = ( 
        
             domain: string, 
        
             bName: browserName = browserDetect() as browserName, 
        
           ): string[] => { 
        
             if (domain.trim() === '') return []; 
        
             const www = new RegExp(/^www[0-9a-z]?\./i); 
        
             const sDot = new RegExp(/^\./); 
        
             let d: string = domain.trim(); 
        
             const domains = new Set<string>(); 
        
             if (sDot.test(d)) { 
        
               // dot at beginning.  .sub.doma.in(.) 
        
               d = d.slice(1); 
        
             } 
        
             // at this point it should be all unison - sub.doma.in(.) 
        
             domains.add(d); // sub.doma.in 
        
             domains.add(`.${d}`); // .sub.doma.in 
        
             if (!www.test(d)) { 
        
               domains.add(`www.${d}`); // www.sub.doma.in 
        
               domains.add(`.www.${d}`); // .www.sub.doma.in 
        
             } 
        
             if (bName === browserName.Chrome || bName === browserName.Opera) { 
        
               const origins: string[] = []; 
        
               for (const d of domains) { 
        
                 origins.push(`http://${d}`); 
        
                 origins.push(`https://${d}`); 
        
               } 
        
               return origins; 
        
             } 
        
             return Array.from(domains); 
        
           };

To fix this bug:

Check if the input domain is an IPv6 address.
If it is, return a set with only the IPv6 address, surrounded by brackets.

The above logic already exists just a few lines below in a different function at

Cookie-AutoDelete/src/services/Libs.ts

Lines 725 to 728 in 659f46d

    
           // Looks like a v6 IP 
        
           if (/^[0-9a-f]*:[0-9a-f:]+$/i.test(cookieDomain)) { 
        
             cookieDomain = `[${cookieDomain}]`; 
        
           }

jthat · 2022-12-17T01:22:45Z

This is still happening for me in 3.8.2. Can anyone else confirm?

Antorell · 2022-12-17T01:42:19Z

It doesn't display an error message anymore for me, but it still doesn't clean cookies on servers with IPV6 address.

Here two screenshots. from the same server, with ipv6 it doesn't find the cookie with the ipv6 "Domain" when I run clean all for this domain, but finds the cookie with the IPV4 "Domain" if I run it on the ipv4 address.

Another thing I just noticed, CAD adds a CookieAutoDeleteBrowsingDataCleanup dummy cookie on the IPV4 address, but it doesn't on the IPV6 address, when I'm connected to the IPV6 address of the server.

EDIT: I forgot to mention, CAD still fails to delete cookies but it deletes the local storage entries for IPV6 address/domain now

IPV6, 1 local storage entry + 1 cookie:

IPV4, 1 cookie:

RubenKelevra · 2023-01-24T00:14:26Z

This is happening for me with Firefox 109.0 on Linux with Addon version 3.8.2.

Please reopen @kennethtran93.

It will lead to a constantly reappearing notification by Gnome about this, which can only be fixed by whitelisting the IPv6 to keep the addon from cleaning attempts:

That's what dbus-monitor "interface='org.freedesktop.Notifications'" shows:

method call time=1674510826.430364 sender=:1.9799 -> destination=:1.38 serial=1002 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify
   string "Firefox"
   uint32 0
   string ""
   string "Error!"
   string "Type error for parameter options (Error processing hostnames.5: Error: Invalid hostname .[fd7a:115c:a1e0:ab12:4843:cd96:6275:1a18]) for browsingData.remove."
   array [
      string "default"
      string "Activate"
   ]
   array [
      dict entry(
         string "desktop-entry"
         variant             string "Firefox"
      )
      dict entry(
         string "sender-pid"
         variant             int64 479139
      )
   ]
   int32 -1
method call time=1674510826.431044 sender=:1.38 -> destination=:1.11 serial=944 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify
   string "Firefox"
   uint32 0
   string ""
   string "Error!"
   string "Type error for parameter options (Error processing hostnames.5: Error: Invalid hostname .[fd7a:115c:a1e0:ab12:4843:cd96:6275:1a18]) for browsingData.remove."
   array [
      string "default"
      string "Activate"
   ]
   array [
      dict entry(
         string "desktop-entry"
         variant             string "Firefox"
      )
      dict entry(
         string "sender-pid"
         variant             uint32 479139
      )
   ]
   int32 -1

kennethtran93 · 2023-01-24T07:09:10Z

This is happening for me with Firefox 109.0 on Linux with Addon version 3.8.2.

Please reopen @kennethtran93.

It will lead to a constantly reappearing notification by Gnome about this, which can only be fixed by whitelisting the IPv6 to keep the addon from cleaning attempts:

That's what dbus-monitor "interface='org.freedesktop.Notifications'" shows:

method call time=1674510826.430364 sender=:1.9799 -> destination=:1.38 serial=1002 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify
   string "Firefox"
   uint32 0
   string ""
   string "Error!"
   string "Type error for parameter options (Error processing hostnames.5: Error: Invalid hostname .[fd7a:115c:a1e0:ab12:4843:cd96:6275:1a18]) for browsingData.remove."
   array [
      string "default"
      string "Activate"
   ]
   array [
      dict entry(
         string "desktop-entry"
         variant             string "Firefox"
      )
      dict entry(
         string "sender-pid"
         variant             int64 479139
      )
   ]
   int32 -1
method call time=1674510826.431044 sender=:1.38 -> destination=:1.11 serial=944 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify
   string "Firefox"
   uint32 0
   string ""
   string "Error!"
   string "Type error for parameter options (Error processing hostnames.5: Error: Invalid hostname .[fd7a:115c:a1e0:ab12:4843:cd96:6275:1a18]) for browsingData.remove."
   array [
      string "default"
      string "Activate"
   ]
   array [
      dict entry(
         string "desktop-entry"
         variant             string "Firefox"
      )
      dict entry(
         string "sender-pid"
         variant             uint32 479139
      )
   ]
   int32 -1

Thanks for the update. I seem to have forgotten that IP Addresses do not have subdomains before the IP Address.

brian6932 · 2023-03-01T18:14:49Z

This is still happening for me in 3.8.2. Can anyone else confirm?

Can confirm, I am getting this as well

Ulisus · 2023-03-03T09:29:35Z

Yes, i am having the same problem as well

brnl · 2023-03-09T17:57:37Z

Came here to report this exact issue :-) I visited my router by its IPv6 address and now I'm stuck with the error notification.

kennethtran93 · 2023-03-10T02:13:24Z

I almost have another patch ready for testing. Hopefully this one resolves the remaining issues.

kennethtran93 · 2023-03-12T01:14:06Z

Can those that uses IPv6 test the new pull request build out, not on their existing profiles?

This has an adjustment whereas the IPv6 now needs to be surrounded by square brackets, inline with how web browsers do/show it. There's a ip parser/validator library that we're using that doesn't make IPv6 valid when it has the outer square brackets (hence why the existing versions do not have the square brackets in the popup and expressions.

This would also require those with IPv6 expressions to manually add outer square brackets to their expressions. I'll try and create an auto update patch that will check existing IPv6 non-regular-expression entries and update those with square brackets.

brnl · 2023-03-12T14:16:14Z

Hi @kennethtran93 there are no more errors but the cookies are not deleted as well. So the cookies for my IPv6 domain still exists after CAD ran a clean. The IPv6 address is also mentioned in every clean run.

kennethtran93 · 2023-03-13T00:46:22Z

@brnl your other issue may be related to #807. I'm also trying to work on that as well.

brnl · 2023-03-14T07:36:42Z

In that case the PR version worked good for me :-)

jthat · 2023-05-18T08:56:23Z

@kennethtran93 I'm still getting the error with PR build 4395017421 on Firefox Developer Edition 114.0b5 with a fresh profile.

git70 · 2023-10-14T16:51:04Z

The issue still occurs on Firefox 115.3.1 ESR on Debian 11 Bullseye

I found a workaround: Manually clear cookies in Preferences > Privacy&Security > Cookies and Site Data > Manage Data
These cookies are not cleared even if I have automatic clearing enabled when closing the browser.

Steps to reproduce: arkenfox/user.js#1743

Revertron · 2023-12-15T15:21:49Z

So, what is the future of this bug?

gilou · 2024-05-14T08:37:47Z

Hi,
Running Firefox 125.0.3 on Ubuntu 22.04.4, CAD 3.8.2, I'm experiencing that same issue:
"Type error for parameter options (Error processing hostnames.1: Error: Invalid hostname .[xxx:xxxx:xxxx:xxxx:xxxx::xxx]) for browsingData.remove."

Gonna see how to test the PR builds if that helps.

wodim added the untested bug/issue Issues that have yet to be tested as per instructions label Dec 2, 2020

wodim changed the title ~~[BUG] "Type error for parameter options" notification~~ [BUG] "Type error for parameter options" notification when clearing data of IPv6 sites Dec 2, 2020

kennethtran93 added the help wanted label Dec 6, 2020

kennethtran93 mentioned this issue Mar 3, 2021

[BUG] Ipv6 Hostname error #1066

Closed

kennethtran93 mentioned this issue Oct 2, 2022

Fix passing IP Addresses into browsingData removal functions #1451

Merged

kennethtran93 added bug Verified Bugs has:pr Issue/Feature Request has been resolved in an upcoming/merged PR and removed help wanted untested bug/issue Issues that have yet to be tested as per instructions labels Oct 11, 2022

kennethtran93 self-assigned this Oct 11, 2022

kennethtran93 closed this as completed in #1451 Nov 19, 2022

kennethtran93 reopened this Jan 24, 2023

kennethtran93 linked a pull request Mar 12, 2023 that will close this issue

Another round of trying to get IPv6 to work. #1498

Open

kennethtran93 mentioned this issue Jun 27, 2023

[Bug] Type error when cleaning after closing a Tab #1581

Closed

1 task

git70 mentioned this issue Oct 14, 2023

[Bug] Cleanup fd80:: ipv6-address #1601

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] "Type error for parameter options" notification when clearing data of IPv6 sites #983

[BUG] "Type error for parameter options" notification when clearing data of IPv6 sites #983

wodim commented Dec 2, 2020

wodim commented Dec 2, 2020

kennethtran93 commented Dec 2, 2020 •

edited

wodim commented Dec 2, 2020

kennethtran93 commented Dec 3, 2020

wodim commented Dec 3, 2020

kennethtran93 commented Dec 3, 2020

kennethtran93 commented Mar 3, 2021

stripwire commented May 28, 2021

ProactiveServices commented Jun 24, 2021

t-makaro commented Aug 2, 2021

tsmithe commented Jan 17, 2022

jgoerzen commented Jan 18, 2022

ddvarpdd commented Feb 9, 2022

suhr commented Apr 6, 2022 •

edited

jthat commented May 24, 2022

Antorell commented Aug 24, 2022 •

edited

Rob--W commented Sep 4, 2022

jthat commented Dec 17, 2022

Antorell commented Dec 17, 2022 •

edited

RubenKelevra commented Jan 24, 2023

kennethtran93 commented Jan 24, 2023

brian6932 commented Mar 1, 2023

Ulisus commented Mar 3, 2023

brnl commented Mar 9, 2023

kennethtran93 commented Mar 10, 2023

kennethtran93 commented Mar 12, 2023 •

edited

brnl commented Mar 12, 2023 •

edited

kennethtran93 commented Mar 13, 2023

brnl commented Mar 14, 2023

jthat commented May 18, 2023

git70 commented Oct 14, 2023

Revertron commented Dec 15, 2023

gilou commented May 14, 2024

[BUG] "Type error for parameter options" notification when clearing data of IPv6 sites #983

[BUG] "Type error for parameter options" notification when clearing data of IPv6 sites #983

Comments

wodim commented Dec 2, 2020

wodim commented Dec 2, 2020

kennethtran93 commented Dec 2, 2020 • edited

wodim commented Dec 2, 2020

kennethtran93 commented Dec 3, 2020

wodim commented Dec 3, 2020

kennethtran93 commented Dec 3, 2020

kennethtran93 commented Mar 3, 2021

stripwire commented May 28, 2021

ProactiveServices commented Jun 24, 2021

t-makaro commented Aug 2, 2021

tsmithe commented Jan 17, 2022

jgoerzen commented Jan 18, 2022

ddvarpdd commented Feb 9, 2022

suhr commented Apr 6, 2022 • edited

jthat commented May 24, 2022

Antorell commented Aug 24, 2022 • edited

Rob--W commented Sep 4, 2022

jthat commented Dec 17, 2022

Antorell commented Dec 17, 2022 • edited

RubenKelevra commented Jan 24, 2023

kennethtran93 commented Jan 24, 2023

brian6932 commented Mar 1, 2023

Ulisus commented Mar 3, 2023

brnl commented Mar 9, 2023

kennethtran93 commented Mar 10, 2023

kennethtran93 commented Mar 12, 2023 • edited

brnl commented Mar 12, 2023 • edited

kennethtran93 commented Mar 13, 2023

brnl commented Mar 14, 2023

jthat commented May 18, 2023

git70 commented Oct 14, 2023

Revertron commented Dec 15, 2023

gilou commented May 14, 2024

kennethtran93 commented Dec 2, 2020 •

edited

suhr commented Apr 6, 2022 •

edited

Antorell commented Aug 24, 2022 •

edited

Antorell commented Dec 17, 2022 •

edited

kennethtran93 commented Mar 12, 2023 •

edited

brnl commented Mar 12, 2023 •

edited