Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log_comment to allowedParams #432

Conversation

profick
Copy link
Contributor

@profick profick commented May 11, 2024

Description

#431

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

Copy link
Collaborator

@mga-chka mga-chka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let a bit of time to the other maintainers to review it

@profick
Copy link
Contributor Author

profick commented May 16, 2024

@mga-chka Hello!
Can you tell me does go-test / build (pull_request) pipeline step failure blocks PR?
And what is an estimate time when we can merge this?

@mga-chka
Copy link
Collaborator

the failure is due to a bug in our CI pipeline (the generation of the code coverage, which is the last step, often fails). So it's not linked to your PR.
I'll merge the PR now. FYI, we're quite busy so we won't release a new version before June

@mga-chka mga-chka merged commit 4e71add into ContentSquare:master May 16, 2024
4 of 5 checks passed
@profick
Copy link
Contributor Author

profick commented May 16, 2024

I'll merge the PR now. FYI, we're quite busy so we won't release a new version before June

Ok, it's fine for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants