Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] allow log_comment in query parameters #431

Open
profick opened this issue May 11, 2024 · 0 comments
Open

[Feature] allow log_comment in query parameters #431

profick opened this issue May 11, 2024 · 0 comments

Comments

@profick
Copy link
Contributor

profick commented May 11, 2024

Is your feature request related to a problem? Please describe.
Currently CHProxy restricts most query_parameters including log_comment.
I need to use log_comment query parameter to add additional information to system.query_log table, in my particular case - to distinguish paragraphs (notes) that run Clickhouse queries from the same CHProxy user. I can't update SETTINGS clause of the query because log_comment is provided via query_parameter in jdbc connection.

Describe the solution you'd like
Add log_comment to allowedParams.
This parameter is safe and doesn't affect caching logic of CHProxy.

Documentation of log_comment

Describe alternatives you've considered
As a general solution for parameters related issues - allow to customize allowedParams list (add custom values) in configuration file. Just like we allow to set user's params but for incoming query parameters, not constant values.
There is possibility of cache related problems, therefore it should be noted in documentation that custom params do not affect caching logic.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant