Skip to content

Commit

Permalink
Fix molgenis#6461 Javascript package versions used in the build shoul…
Browse files Browse the repository at this point in the history
…d be reproducible

WIP
Update yarn to release version 1.1
Update maven frontend plugin to 1.6 ( includes yarn fix)
Move configuration of frontend plugin version to central pom and use variable in sub-poms
  • Loading branch information
ConnorStroomberg committed Sep 29, 2017
1 parent 39d800b commit e6d46d4
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions molgenis-core-ui/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>0.0.27</version>
<version>${frontend-maven-plugin.version}</version>
<executions>
<execution>
<id>install node and npm</id>
Expand Down Expand Up @@ -129,7 +129,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>0.0.27</version>
<version>${frontend-maven-plugin.version}</version>
<executions>
<execution>
<id>webpack production build</id>
Expand Down
2 changes: 1 addition & 1 deletion molgenis-metadata-manager/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.4</version>
<version>${frontend-maven-plugin.version}</version>
<configuration>
<workingDirectory>src/main/frontend</workingDirectory>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion molgenis-navigator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.4</version>
<version>${frontend-maven-plugin.version}</version>
<configuration>
<workingDirectory>src/main/frontend</workingDirectory>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion molgenis-one-click-importer/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.4</version>
<version>${frontend-maven-plugin.version}</version>
<configuration>
<workingDirectory>src/main/frontend</workingDirectory>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion molgenis-searchall/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.4</version>
<version>${frontend-maven-plugin.version}</version>
<configuration>
<workingDirectory>src/main/frontend</workingDirectory>
</configuration>
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@
<postgres.version>9.4.1211</postgres.version>
<sonar.jacoco.itReportPath>${project.basedir}/../target/jacoco-it.exec</sonar.jacoco.itReportPath>
<mockito.version>2.7.22</mockito.version>
<frontend-maven-plugin.version>1.6</frontend-maven-plugin.version>
<node.version>v6.11.0</node.version>
<!-- Update to 1.x when https://github.com/eirslett/frontend-maven-plugin/issues/647 is fixed -->
<yarn.version>v0.27.5</yarn.version>
<yarn.version>v1.1.0</yarn.version>
</properties>

<distributionManagement>
Expand Down

0 comments on commit e6d46d4

Please sign in to comment.