Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality for account signature checking. #312

Merged
merged 8 commits into from
Jul 15, 2023
Merged

Add functionality for account signature checking. #312

merged 8 commits into from
Jul 15, 2023

Conversation

abizjak
Copy link
Member

@abizjak abizjak commented Jul 9, 2023 •
edited

Purpose

Add host functions for querying account keys, and checking account signatures.

Closes #309

Depends on

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@abizjak abizjak force-pushed the acc-sig-checksd branch 2 times, most recently from a80bc71 to 8617c45 Compare July 9, 2023 19:24
@abizjak abizjak requested review from DOBEN and limemloh and removed request for DOBEN July 10, 2023 18:36
DOBEN
DOBEN approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/account-signature-checks/Cargo.toml Show resolved Hide resolved
.github/workflows/linter.yml Show resolved Hide resolved
concordium-std/src/impls.rs Outdated Show resolved Hide resolved
concordium-std/src/impls.rs Show resolved Hide resolved
concordium-std/src/test_infrastructure.rs Outdated Show resolved Hide resolved
concordium-std/src/test_infrastructure.rs Outdated Show resolved Hide resolved
limemloh
limemloh approved these changes Jul 12, 2023
View reviewed changes
concordium-std/src/impls.rs Outdated Show resolved Hide resolved
concordium-std/src/impls.rs Outdated Show resolved Hide resolved
concordium-std/src/impls.rs Outdated Show resolved Hide resolved
concordium-std/src/impls.rs Show resolved Hide resolved
concordium-std/src/traits.rs Show resolved Hide resolved
concordium-std/src/types.rs Show resolved Hide resolved
concordium-std/src/types.rs Show resolved Hide resolved
concordium-std/src/types.rs Show resolved Hide resolved
concordium-std/src/types.rs Show resolved Hide resolved
examples/account-signature-checks/src/lib.rs Show resolved Hide resolved
@abizjak abizjak force-pushed the acc-sig-checksd branch 2 times, most recently from 60c5837 to d9d1177 Compare July 15, 2023 12:37
@abizjak abizjak merged commit cda0717 into main Jul 15, 2023
126 checks passed
@abizjak abizjak deleted the acc-sig-checksd branch July 15, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limemloh limemloh limemloh approved these changes

@DOBEN DOBEN DOBEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support retrieving keys and checking signatures with account keys in concordium-std.
3 participants
@abizjak @limemloh @DOBEN