Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change severity of logs for certain gRPC status codes #1169

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented May 14, 2024

Purpose

Fixes #1057

Changes

  • Using DEBUG severity for logging of failed gRPC API requests.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@limemloh limemloh marked this pull request as ready for review May 14, 2024 07:21
@limemloh limemloh requested a review from td202 May 14, 2024 07:22
Copy link
Contributor

@lassemand lassemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I believe it would make more sense to also include RESOURCE_EXHAUSTED but I can also argue for why it should not be there. I do believe this one is usually cast when the node is gracefully exhausted. (Else it would be down?)

If a person tries to DoS us what should we do? On the one hand it would be nice to provide the error logs, but on the other hand, the server is not in a bad state, only the client is unable to request the server.

I can accept both.

concordium-node/src/grpc2.rs Outdated Show resolved Hide resolved
concordium-node/src/grpc2.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@limemloh limemloh merged commit 8dca42e into main May 27, 2024
3 checks passed
@limemloh limemloh deleted the grpc-log-level branch May 27, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change log level for grpc not_found queries
3 participants