Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rust 1.73 on Windows. #1137

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Support Rust 1.73 on Windows. #1137

merged 4 commits into from
Apr 9, 2024

Conversation

td202
Copy link
Contributor

@td202 td202 commented Apr 2, 2024

Purpose

Support Rust version 1.73 on Windows. This changes how the Haskell code is linked against Rust libraries to use dynamic (rather than static) linking on Windows.

Changes

  • The smart_contract_execution_engine static library is no longer copied to lib, and is removed if already present.
  • The smart_contract_execution_engine.dll is copied to the install directory in a post-copy hook, to ensure that it is available when binaries and tests are run.
  • The DLLs included in the installer are changed to include the DLLs sha_2.dll, concordium_base.dll and smart_contract_execution_engine.dll. libunwind.dll is no longer required.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 requested review from abizjak and limemloh April 2, 2024 15:36
concordium-node/src/utils.rs Outdated Show resolved Hide resolved
@td202 td202 merged commit 9c46f15 into main Apr 9, 2024
2 checks passed
@td202 td202 deleted the update-rust-1.73 branch April 9, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants