[BRO-13] Payload decoding in the browser wallet of the CIS3 standard #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update examples with new signCIS3Message
DOBEN
reviewed
Apr 24, 2024
Update CHANGELOG.md, README.md, dApp version Updated function names Removed unused constants
3 tasks
DOBEN
reviewed
Apr 26, 2024
| @@ -1,5 +1,9 @@ | |||
| ## Unreleased changes | |||
|
|
|||
| ## 2.0.3 | |||
|
|
|||
| - Change the dApp to use new signCIS3Message from BrowserWallet | |||
There was a problem hiding this comment.
Suggested change
| - Change the dApp to use new signCIS3Message from BrowserWallet | |
| - Change the dApp to use new `signCIS3Message` function from the BrowserWallet. |
| @@ -1,5 +1,9 @@ | |||
| ## Unreleased changes | |||
|
|
|||
| ## 1.0.4 | |||
|
|
|||
| - Change the dApp to use new signCIS3Message from BrowserWallet | |||
There was a problem hiding this comment.
- Change the dApp to use new
signCIS3Messagefunction from the BrowserWallet.
DOBEN
approved these changes
Apr 26, 2024
Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update examples with new signCIS3Message
Purpose
With sign CIS3 message, we can explicitly sign new message standard and decode payload. But in this case we should send all additional data as message parameters, because end result message will be created at browser wallet side.
Checklist
hard-to-understand areas.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.