Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add airdrop example #18

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

KatasonovYP
Copy link

@KatasonovYP KatasonovYP commented Jul 19, 2023

Purpose

Example dApp for showcasing how to integrate with a smart contract on the Concordium blockchain.
The project was bootstrapped with Vite.

Changes

Adding a project to the repository

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

airdrop/readme.md Outdated Show resolved Hide resolved
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments and let me know if something is unclear.

airdrop/package.json Outdated Show resolved Hide resolved
airdrop/package.json Outdated Show resolved Hide resolved
airdrop/postcss.config.js Outdated Show resolved Hide resolved
airdrop/readme.md Outdated Show resolved Hide resolved

![ccd-transaction-1.png](docs/ccd-transaction-init.png)

If you confirm it, you will see a loader with a link to concordium explorer where you can get more information about the transaction.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the developer documentation, we refer to the the below picture as the concordium dashboard while the concordium explorer is CCDScan https://ccdscan.io/. This is the convention for the developer documentation also I know that on the general public webpage we are not consistent with this:
https://concordium.com/block-explorers/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused as to what exactly needs to be fixed

Copy link
Member

@DOBEN DOBEN Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above picture is from the Concordium dashboard. Your front end links to the dashboard. Since your documentation talks about Concordium explorer, it would be good to link to https://ccdscan.io/{txHash} in the front end and update the pictures or vice versa. I suggest using the Concordium explorer so.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added link to concordium explorer [concordium explorer](https://dashboard.testnet.concordium.com/lookup/{txhash})

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also be at this addresshttps://testnet.ccdscan.io/?dcount=1&dentity=transaction&dhash={txhash}, but dashboard.testnet.concordium.com seems more informative to me

airdrop/src/widgets/form-init/hooks/use-form-init.ts Outdated Show resolved Hide resolved
airdrop/src/widgets/form-init/lib/post-ipfs.ts Outdated Show resolved Hide resolved
airdrop/src/widgets/form-init/ui/form-init.tsx Outdated Show resolved Hide resolved
airdrop/vite.config.ts Outdated Show resolved Hide resolved
airdrop/vite.config.ts Outdated Show resolved Hide resolved
@KatasonovYP
Copy link
Author

When I was testing the program I was asked to make an excel table with all the tests. Code fragments were written in a separate branch, which automatically added transactions to the table (something like logging) and I only had to add a description of the test. Is it necessary to add this code here?

https://docs.google.com/spreadsheets/d/18o118G5LsWbo9gt-Mte5dGumlSKrPJwvRitZHAGN7PY/edit#gid=1412407911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants