[BRO-9] Add addCIS2Tokens to the wCCD example #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerenbf
reviewed
Apr 3, 2024
Co-authored-by: Søren Bruus Zeppelin <sz@concordium.com>
Co-authored-by: Søren Bruus Zeppelin <sz@concordium.com>
Co-authored-by: Søren Bruus Zeppelin <sz@concordium.com>
Clean yarn.lock
Use BrowserWalletConnector instead of detectConcordiumProvider
Ivan-Mahda
commented
Apr 3, 2024
abizjak
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It would be both good user experience to suggest to add the newly wrapped token to the user's wallet, as well as a good example to demonstrate this functionality in an example app to spread its visibility.
Changes
Created new button "Add Token to wallet" that calls addCIS2Tokens from browser-wallet-api-helpers
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.
Screencast from 27.03.24 12:13:57.webm