Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remediations for security_patches_up_to_date #11992

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented May 13, 2024

Description:

Remove remediations for security_patches_up_to_date

Rationale:

Part of removing this rule from various profiles.

@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label May 13, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 13, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11992
This image was built from commit: f01dffa

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11992

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11992 make deploy-local

Copy link

codeclimate bot commented May 13, 2024

Code Climate has analyzed commit f01dffa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

@Mab879 This isn't the right fix, there are products that still actively use the rule security_patches_up_to_date, for example Oracle, SLES, Ubuntu. You can find them by looking for oval_feed_url variable. I think we shouldn't change them.
Try to change the platform key in the remediations

@Mab879
Copy link
Member Author

Mab879 commented May 14, 2024

There is another PR that is better, closing.

@Mab879 Mab879 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants