Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align sshd_use_approved_kex_ordered_stig with Ubuntu STIG #11987

Merged
merged 4 commits into from
May 10, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented May 10, 2024

Description:

Rationale:

  • Checking just for a subset does not meet the requirement of having the algorithms in the exact same order (as specified in the STIG), because it is possible to specify only the last algorithm, which is effectively the same as specifying them in the wrong order

mpurg added 4 commits May 10, 2024 08:49
The remediation now uses the bash_sshd_remediation macro.
The OVAL now also allows distributed configs.

The implementation is based on the template `sshd_lineinfile`,
modified to allow checking for FIPS compliant OS.
- Enabled Ubuntu22.04 product
- Added tests for distributed configs
- Added tests for conflicting params
- Fixed case sensitivity in sed
Copy link

openshift-ci bot commented May 10, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 10, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11987
This image was built from commit: 3a14850

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11987

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11987 make deploy-local

@dodys dodys requested a review from a team May 10, 2024 07:41
@dodys dodys added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels May 10, 2024
@dodys dodys self-assigned this May 10, 2024
Copy link

codeclimate bot commented May 10, 2024

Code Climate has analyzed commit 3a14850 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit d71b7db into ComplianceAsCode:master May 10, 2024
107 of 108 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants