Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ufw is active #11984

Merged
merged 3 commits into from May 14, 2024
Merged

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Only check whether the ufw is active after ufw service is enable instead of configuring the ufw.

Rationale:

  • Ensure ongoing compliance with remote access policies by checking the status of Uncomplicated Firewall (ufw)

Only check whether the ufw is active after ufw service is enable instead of configuring the ufw.
@alanmcanonical alanmcanonical requested a review from a team as a code owner May 9, 2024 15:09
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 9, 2024
Copy link

openshift-ci bot commented May 9, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented May 9, 2024

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2004 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 9, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11984
This image was built from commit: 4e3f121

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11984

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11984 make deploy-local

@Mab879
Copy link
Member

Mab879 commented May 9, 2024

/packit retest-failed

@dodys dodys self-assigned this May 10, 2024
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. STIG STIG Benchmark related. labels May 10, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor fix, and after discussing to @mpurg we agreed on adding this to 20.04 stig too, as it is clearly missing. Could you add it please?

Copy link

codeclimate bot commented May 13, 2024

Code Climate has analyzed commit 4e3f121 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented May 14, 2024

/packit build

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 81e9112 into ComplianceAsCode:master May 14, 2024
104 of 108 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants