Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accounts_password_set_max_life_root to unselect_rules_list #11981

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • extend the list of rules which can be excluded from the datastream

Rationale:

  • if this rule is remediated, Automatus can't retrieve test results because it is forced to change the password

Review Hints:

Try with and without this PR:

  1. ./build_product rhel9
  2. cd tests
  3. ./ds_unselect_rules.sh ../build/ssg-rhel9-ds.xml unselect_rules_list
  4. python automatus.py profile --libvirt qemu:///system rhel9 --datastream /tmp/ssg-rhel9-ds.xml anssi_bp28_high

if this rule is remediated, Automatus can't retrieve test results because it is forced to change the password
@vojtapolasek vojtapolasek added the Test Suite Update in Test Suite. label May 9, 2024
@vojtapolasek vojtapolasek added this to the 0.1.74 milestone May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this May 9, 2024
Copy link

github-actions bot commented May 9, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11981
This image was built from commit: 7e144ee

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11981

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11981 make deploy-local

Copy link

codeclimate bot commented May 9, 2024

Code Climate has analyzed commit 7e144ee and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 7ef2387 into ComplianceAsCode:master May 9, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants