Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11898 issue #11899

Merged
merged 1 commit into from Apr 29, 2024
Merged

Fix #11898 issue #11899

merged 1 commit into from Apr 29, 2024

Conversation

marcofortina
Copy link
Contributor

Description:

This use crontab as group owner for /etc/cron.allow file on Ubuntu.

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2204

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2204-playbook-cis_level1_server.yml --tags "file_groupowner_cron_allow"

To test changes with bash, run the remediation sections: xccdf_org.ssgproject.content_rule_file_groupowner_cron_allow

Expected output:

Title   Verify Group Who Owns /etc/cron.allow file
Rule    xccdf_org.ssgproject.content_rule_file_groupowner_cron_allow
Result  pass

@marcofortina marcofortina requested a review from a team as a code owner April 26, 2024 12:28
Copy link

openshift-ci bot commented Apr 26, 2024

Hi @marcofortina. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 26, 2024
@dodys dodys self-assigned this Apr 26, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. CIS CIS Benchmark related. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 26, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcofortina marcofortina changed the title Fix #11898 Fix #11898 issue Apr 26, 2024
Copy link

github-actions bot commented Apr 26, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11899
This image was built from commit: f810eff

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11899

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11899 make deploy-local

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link

codeclimate bot commented Apr 26, 2024

Code Climate has analyzed commit f810eff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member

/packit 432447

@dodys
Copy link
Contributor

dodys commented Apr 29, 2024

/packit test

@dodys dodys merged commit a4491f0 into ComplianceAsCode:master Apr 29, 2024
113 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 29, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with rule "Verify Group Who Owns /etc/cron.allow file"
4 participants