Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dconf profiles in Ubuntu CIS/STIG profiles #11874

Merged
merged 3 commits into from May 6, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 24, 2024

Description:

Modified Ubuntu profiles to enable dconf profiles gdm and user.

Rationale:

On Ubuntu, dconf profiles gdm and user are not explictly configured by default. When the profiles aren't explicitly
defined and don't point to gdm.d and local.d dconf databases, respectively, the remediations from dconf rules will have no affect on gnome settings and the checks will give false positives.

The rules that are affected on Ubuntu:

  • dconf_gnome_banner_enabled
  • dconf_gnome_disable_automount
  • dconf_gnome_disable_automount_open
  • dconf_gnome_disable_autorun
  • dconf_gnome_disable_ctrlaltdel_reboot
  • dconf_gnome_disable_user_list
  • dconf_gnome_login_banner_text
  • dconf_gnome_screensaver_idle_delay
  • dconf_gnome_screensaver_lock_delay
  • dconf_gnome_screensaver_lock_enabled

@mpurg mpurg requested a review from a team as a code owner April 24, 2024 09:44
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 24, 2024
Copy link

openshift-ci bot commented Apr 24, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpurg mpurg marked this pull request as draft April 24, 2024 09:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 24, 2024
Copy link

github-actions bot commented Apr 24, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11874
This image was built from commit: 6901d00

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11874

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11874 make deploy-local

@mpurg mpurg force-pushed the ubuntu_dconf_enable_profiles branch 2 times, most recently from 3f73342 to 4b3cdc4 Compare April 24, 2024 18:00
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mpurg mpurg force-pushed the ubuntu_dconf_enable_profiles branch from 4b3cdc4 to 1f004df Compare April 24, 2024 18:03
@mpurg mpurg marked this pull request as ready for review April 24, 2024 18:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 24, 2024
@mpurg mpurg force-pushed the ubuntu_dconf_enable_profiles branch from 1f004df to 0ae198a Compare April 24, 2024 20:29
@marcusburghardt marcusburghardt added the Ubuntu Ubuntu product related. label Apr 26, 2024
@dodys dodys self-assigned this Apr 26, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 26, 2024
@dodys
Copy link
Contributor

dodys commented Apr 26, 2024

/packit retest

On Ubuntu, dconf profiles `gdm` and `user` are not explictly
configured by default. When the profiles aren't explicitly
defined and don't point to `gdm.d` and `local.d` dconf databases,
respectively, the remediations from dconf rules will have no affect
on gnome settings and the checks will give false positives.

The rules that are affected on Ubuntu:
- dconf_gnome_banner_enabled
- dconf_gnome_disable_automount
- dconf_gnome_disable_automount_open
- dconf_gnome_disable_autorun
- dconf_gnome_disable_ctrlaltdel_reboot
- dconf_gnome_disable_user_list
- dconf_gnome_login_banner_text
- dconf_gnome_screensaver_idle_delay
- dconf_gnome_screensaver_lock_delay
- dconf_gnome_screensaver_lock_enabled
@mpurg mpurg force-pushed the ubuntu_dconf_enable_profiles branch from 0ae198a to 38c087a Compare April 29, 2024 08:00
@dodys
Copy link
Contributor

dodys commented Apr 29, 2024

/packit test

@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit retest-failed

@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

@dodys
Copy link
Contributor

dodys commented May 2, 2024

@marcusburghardt

@dodys
Copy link
Contributor

dodys commented May 6, 2024

/packit build

@marcusburghardt
Copy link
Member

@mpurg , currently we can't re-trigger the stalled testing-farm tests in CI, unfortunately. Could you rebase or simply amend the last commit to re-trigger them, please?

@mpurg mpurg force-pushed the ubuntu_dconf_enable_profiles branch from 38c087a to 6901d00 Compare May 6, 2024 14:05
Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit 6901d00 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented May 6, 2024

/packit test

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 00285b3 into ComplianceAsCode:master May 6, 2024
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants