Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule set_password_hashing_algorithm_systemauth to Ubuntu STIG profile #11864

Merged
merged 3 commits into from Apr 29, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 22, 2024

Description:

  • Modified bash and OVAL of set_password_hashing_algorithm_systemauth to use the correct pathname (/etc/pam.d/common-password) and control ([success=... ]) on Ubuntu.
  • Added to Ubuntu STIG profile

Rationale:

  • Satisfies STIG UBTU-22-611055

@mpurg mpurg requested a review from a team as a code owner April 22, 2024 15:29
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 22, 2024
Copy link

openshift-ci bot commented Apr 22, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 22, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11864
This image was built from commit: 1ca1e4a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11864

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11864 make deploy-local

@marcusburghardt marcusburghardt added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Apr 26, 2024
@dodys dodys self-assigned this Apr 26, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 26, 2024
Modified bash and OVAL of set_password_hashing_algorithm_systemauth
to use the correct pathname (/etc/pam.d/common-password) and control
([success=... ]) on Ubuntu.
Copy link

codeclimate bot commented Apr 29, 2024

Code Climate has analyzed commit 1ca1e4a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 2c2507f into ComplianceAsCode:master Apr 29, 2024
113 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 29, 2024
@Mab879 Mab879 added OVAL OVAL update. Related to the systems assessments. Bash Bash remediation update. Update Profile Issues or pull requests related to Profiles updates. labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants