Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package name for libpam-pkcs11 on Ubuntu #11854

Merged
merged 1 commit into from May 7, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 18, 2024

Description:

  • Corrected the package name for libpam-pkcs11 on Ubuntu
  • This fixes rule smartcard_configure_cert_checking on Ubuntu (UBTU-22-612025), which relies on install_smartcard_packages and possibly other rules as well.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 18, 2024
Copy link

openshift-ci bot commented Apr 18, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Apr 18, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 18, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11854
This image was built from commit: c79ac70

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11854

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11854 make deploy-local

@dodys dodys requested a review from a team April 18, 2024 17:27
@dodys dodys self-assigned this Apr 18, 2024
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 18, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Apr 18, 2024
@Mab879
Copy link
Member

Mab879 commented Apr 18, 2024

Run ./tests/test_product_stability.py --update-reference-data ./products ./tests/data/product_stability and commit those changes to fix CI.

@mpurg
Copy link
Contributor Author

mpurg commented Apr 18, 2024

@Mab879 I added the changes made to tests/data/product_stability/ubuntu2204.yml but not the new files that were created (rhel10.yml and openeuler2203.yml).

@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

2 similar comments
@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

@dodys
Copy link
Contributor

dodys commented May 6, 2024

/packit build

@dodys
Copy link
Contributor

dodys commented May 6, 2024

@mpurg could you please rebase this PR for the tests to get unstuck

@mpurg mpurg force-pushed the ubuntu_2204_stig_612025 branch from ae07d5b to c79ac70 Compare May 6, 2024 12:19
@mpurg
Copy link
Contributor Author

mpurg commented May 6, 2024

@dodys rebased

Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit c79ac70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented May 6, 2024

/packit test

@dodys
Copy link
Contributor

dodys commented May 7, 2024

/packit build

@dodys dodys merged commit 4f976c8 into ComplianceAsCode:master May 7, 2024
113 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants