Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and modify rules file/dir_permissions_system_journal #11840

Merged
merged 1 commit into from Apr 29, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 17, 2024

Description:

  • New rule for auditing permissions of /var/log/journal
  • Satisfies STIG requirement UBTU-22-232027
  • Modified existing rule file_permissions_system_journal

@mpurg mpurg requested a review from a team as a code owner April 17, 2024 08:18
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 17, 2024
Copy link

openshift-ci bot commented Apr 17, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2204 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 17, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11840
This image was built from commit: 2756e38

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11840

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11840 make deploy-local

@dodys dodys self-assigned this Apr 17, 2024
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 17, 2024
@dodys dodys requested review from a team April 17, 2024 11:05
@dodys
Copy link
Contributor

dodys commented Apr 17, 2024

Added red-hatters and suse maintainers as this new rule might be relevant for them
@marcusburghardt @Mab879 @teacup-on-rockingchair

@marcusburghardt
Copy link
Member

Please, make sure the new rule is mapped to a component in https://github.com/ComplianceAsCode/content/tree/master/components

@mpurg
Copy link
Contributor Author

mpurg commented Apr 18, 2024

@marcusburghardt sorry for that, I wasn't aware of this requirement. Added all new rules to the components.

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Satisfies STIG requirement UBTU-22-232027
- New rule for auditing permissions of /var/log/journal
- Modified existing rule file_permissions_system_journal
Copy link

codeclimate bot commented Apr 29, 2024

Code Climate has analyzed commit 2756e38 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 9c989f7 into ComplianceAsCode:master Apr 29, 2024
110 of 113 checks passed
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants