Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new rule audit_rules_var_log_journal #11833

Closed
wants to merge 3 commits into from
Closed

Add new rule audit_rules_var_log_journal #11833

wants to merge 3 commits into from

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 17, 2024

Description:

  • New rule for auditing /var/log/journal directory
  • Satisfies STIG requirement UBTU-22-654190
  • Based on rule audit_rule_sudoers_d

@mpurg mpurg requested a review from a team as a code owner April 17, 2024 08:15
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2204 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11833
This image was built from commit: d988ed7

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11833

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11833 make deploy-local

@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 17, 2024
@dodys dodys self-assigned this Apr 17, 2024
@dodys dodys requested review from a team April 17, 2024 11:14
@dodys
Copy link
Contributor

dodys commented Apr 17, 2024

Added red-hatters and suse maintainers as this new rule might be relevant for them
@marcusburghardt @Mab879 @teacup-on-rockingchair

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 21, 2024

@mpurg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-images 3d8e38f link true /test 4.16-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mpurg mpurg mentioned this pull request Apr 23, 2024
Merged
@mpurg mpurg marked this pull request as draft April 23, 2024 08:33
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 23, 2024
@mpurg
Copy link
Contributor Author

mpurg commented Apr 23, 2024

I opened another PR with proposed changes to audit_rules_watch: #11869
Setting to draft until that is merged.

@mpurg
Add additional criteria to audit_rules_watch template
b7aad7f 
Added criteria for checking if augenrules/auditctl is in use,
analogous to template `audit_rules_usergroup_modifications`.
@mpurg
Allow using custom key in audit_rules_watch template
c5358c5
@mpurg
Add new rule audit_rules_var_log_journal
d988ed7 
- New rule for auditing /var/log/journal directory
- Satisfies STIG requirement UBTU-22-654190
- Uses template `audit_rules_watch`
@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 29, 2024

Code Climate has analyzed commit d988ed7 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys dodys closed this in #11869 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teacup-on-rockingchair teacup-on-rockingchair teacup-on-rockingchair left review comments

Assignees

@dodys dodys

Labels
do-not-merge/work-in-progress Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpurg @dodys @teacup-on-rockingchair