Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 update golang to 1.21 #491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Feb 2, 2024

No description provided.

Copy link

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 2, 2024
@BhargaviGudi
Copy link
Collaborator

Verification passed with 4.15.0-rc.5 + code from PR #491

  1. Install CO with PR 🧹 update golang to 1.21 #491
  2. Create ssb
$ oc compliance bind -N test -S default-auto-apply profile/ocp4-cis profile/ocp4-cis-node
Creating ScanSettingBinding test
$ oc get suite -w
NAME   PHASE         RESULT
test   AGGREGATING   NOT-AVAILABLE
test   AGGREGATING   NOT-AVAILABLE
test   DONE          NON-COMPLIANT
test   DONE          NON-COMPLIANT
$ oc get pods
NAME                                             READY   STATUS    RESTARTS        AGE
compliance-operator-754cb8f9bf-stlh5             1/1     Running   1 (6m42s ago)   6m47s
ocp4-openshift-compliance-pp-64c669c697-msc8d    1/1     Running   0               6m39s
rhcos4-openshift-compliance-pp-97796b947-5cd8q   1/1     Running   0               6m39s

@BhargaviGudi
Copy link
Collaborator

/label qe-approved

@rhmdnd
Copy link
Author

rhmdnd commented May 15, 2024

This is failing serial and parallel e2e testing due to images with the wrong glibc version:

compliance-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by compliance-operator)
compliance-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by compliance-operator)

Copy link

openshift-ci bot commented May 16, 2024

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 63ff63f link true /test e2e-aws-serial
ci/prow/e2e-aws-parallel 63ff63f link true /test e2e-aws-parallel
ci/prow/e2e-rosa 63ff63f link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Author

rhmdnd commented May 16, 2024

We've been bitten by this before - here is an example of what we did to fix:

#373

@rhmdnd rhmdnd requested review from yuumasato and removed request for jhrozek May 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants