Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if file responds to filename as well as to_path #2043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lsylvester
Copy link

After upgrading to rails 5 and sprockets 3.5.2, Compass::Core::SassExtensions::Functions::ImageSize::ImageProperties is being initialised with a Sprockets::Asset which no longer responds to to_path.

This adds an additional check to to see the file passed in responds to filename and uses that if it is available to prevent the no implicit conversion of Sprockets::Asset into String errors.

Fixes #2042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant