Do not send a rejection reply in case of auto mails #5
Conversation
|
Why not combine both in 1 PR? |
|
Since we are talking about two extensions with two repositories (combodo/combodo-email-synchro.git and combodo/itop-standard-email-synchro.git) I thought this is not possible, is it? |
|
Oh whoops, missed that 😄 |
| @@ -1201,6 +1202,7 @@ EOF | |||
| $oRawEmail->SendAsAttachment($sReplyTo, $sReplyFrom, $sReplySubject, $sReplyBody); | |||
|
|
|||
| $this->sLastError .= " - Replied to sender on ".date('r'); | |||
| } | |||
There was a problem hiding this comment.
Indentation is different compared to the surrounding code.
There was a problem hiding this comment.
Damn.. it was looking pretty right in my local editor, I their was a tab size of 2, but some of those tabs are spaces and some not...
But you are right, combodo coding standards suggest to configure it with 4 spaces..
I will correct this
larhip
force-pushed
the
recjetion_reply_not_to_automails
branch
from
ec6e5a7
to
0e72f77
Compare
|
Hello Lars, I'll check this PR on friday, would you update/rebase you branch on master in the meantime? Thanks |
larhip
force-pushed
the
recjetion_reply_not_to_automails
branch
from
0e72f77
to
f1b782f
Compare
Molkobain
moved this from First review needed
to Pending technical review
in Combodo PR dashboard
|
Hello Lars, We reviewed the PR today it seems that the new method is only used for unknown callers, what about auto-reply of known callers? Edit: What I meant if that from our point of view it seems that this auto reply management could be applied in other use cases. We won't ask you to implement them, we were just wondering if you encountered them. |
| $sReplyTo = $oEmail->sCallerEmail; | ||
| $aTo = $oRawEmail->GetTo(); | ||
| $sReplyFrom = $aTo[0]['email']; | ||
| $this->Trace("From: ".$sReplyFrom."\nTo: ".$sReplyTo."\n".$sReplySubject."\n\n".$sReplyBody); |
There was a problem hiding this comment.
| $this->Trace("From: ".$sReplyFrom."\nTo: ".$sReplyTo."\n".$sReplySubject."\n\n".$sReplyBody); |
Molkobain
moved this from Pending technical review
to Pending functional review
in Combodo PR dashboard
larhip
force-pushed
the
recjetion_reply_not_to_automails
branch
from
f1b782f
to
27feacb
Compare
|
Hi @Molkobain , you are right the method For this small use case "unknown caller" I have implemented it because it was the most urgent use case for us: With out this implementation we got sometime endless loop between iTop (rejection reply) an the mail server (auto-reply):
Hope I could make my point clear :-) |
|
Yes perfect thanks! |
|
Accepted during functional review. Feature will always be used for unknown callers. |
Molkobain
moved this from Pending functional review
to Pending contributor update
in Combodo PR dashboard
Prevent endless email loops by not sending a rejection reply for auto replies.
Is PR is based on PR#12 in combodo-email-synchro