chore(requirements): Apply correct minimal versions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning for PHPUnit the tests code isn't ready yet for versions > 6 |
|
It blocks new people to be able to install/use phpunit if I recall correctly. |
|
Yes please, remove it for now, so we can push this PR forward in the meantime. |
Hipska
commented
Apr 29, 2024
Molkobain
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current composer.json doesn't mach the versions supported according to the documentation, this makes it hard to test the collector code for supported versions higher than PHP 7.0.
Next to that, the version checker checks for PHP 5.3+, but since only PHP 7.x+ is supported, I changed the default version value.
I hope this PR description is clear enough, the questions/steps in the request template seemed not fitting for this kind of cleanup.