N°7234 - Add the possibility of mapping the same CSV column twice or more #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipska
suggested changes
Feb 12, 2024
Molkobain
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Unit test isn't working as expected:
- If the duplicated field is something other than the primary key, it doesn't work
- If 2 or more fields are duplicated it doesn't work, only the first one seem to work
- Columns orders in the generated CSV changes when you add a duplicated field
Anne-Cath, you can talk to Denis or me about these comments, we reviewed it together.
Molkobain
changed the title
Hipska
suggested changes
Apr 25, 2024
Hipska
approved these changes
Apr 25, 2024
accognet
force-pushed
the
feature/7234-map_csv_column_twice
branch
from
d605a38
to
d2314c7
Compare
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
accognet
force-pushed
the
feature/7234-map_csv_column_twice
branch
from
d2314c7
to
334edb4
Compare
Molkobain
approved these changes
May 7, 2024
|
All good, you can squash & merge. Mind to keep the PR number in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example :
<PersonCollector><csv_file>collectors/Person_import.csv</csv_file><separator>,</separator><fields><primary_key>email</primary_key><first_name>first_name</first_name><name>name</name><status>status</status><org_id>org_id</org_id><email>email</email></fields></PersonCollector>