feat(ModuleInstaller): Add method to rename tables in the DB

[Hipska]

Base information

Question	Answer
Related to a SourceForge thead / Another PR / Combodo ticket?	N/A
Type of change?	Enhancement

Objective

To have a helper method that can rename a table in DB during setup. The helper method can silently ignore the renaming if the origin table doesn't exist or the destination table already exists. This to avoid errors when running the setup again after the migration has ben done before.

Proposed solution

Creation of ModuleInstallerAPI::MoveColumnInDB.

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• Is the PR clear and detailled enough so anyone can understand digging in the code?

[Molkobain]

See comment on test

[piRGoif]

Great work, thanks !
My remarks are mostly questions, and also we may add more uses cases in the phpunit

[piRGoif]

I would also test :

• orig and dest on the same existing table name
• orig and dest on the same non existing table name
• orig on a non existing table name
• dest on an existing table name

This may be easier to code using a dataprovider returning orig and dest names, and expected result ?

[Molkobain]

Technical review:

• Unit test:
  • Move table revert in tearDown() method for better robustness in case there is an issue within the test method
• New method:
  • Add SetupLog message in exit conditions (except the !MetaModel::DBExists(false)). See RenameEnumValueInDB() for a real example, MoveColumnInDB() is a bad one.