N°5039 - DataSynchro: TEXT field too small for big linkset

[Hipska]

This change is in order to be able to synchronise large linksets.

[piRGoif]

Hello Thomas,
Thanks for the contribution !

I see the method you modified will be called for datasource table creation in \SynchroDataSource::AfterInsert
But when the table already exists, seems like it will raise an error in \SynchroDataSource::CheckDBConsistency right ? Did you test it ?

[Hipska]

Hmm, I only tested in iTop 3.0, but there the method was a bit different.

The consistency check will indeed complain, but wouldn't the setup try to update the column instead?

Edit: Seems to be the case for 3.0:

iTop/synchro/synchrodatasource.class.inc.php

Lines 1106 to 1117 in 4c626d0

	} elseif (!CMDBSource::IsSameFieldTypes($sColumnDef, CMDBSource::GetFieldSpec($sTable, $sColName))) {
	$bFixNeeded = true;
	$bOneColIsMissing = true;
	if (count($aColumns) > 1) {
	echo "Incorrect column '$sColName' (".CMDBSource::GetFieldSpec($sTable,
	$sColName).' instead of '.$sColumnDef."), in the table '$sTable' for the data synchro task ".$this->GetName().' ('.$this->GetKey()."). The columns '".implode("', '",
	$aColumns)." will be re-created.'.\n";
	} else {
	echo "Incorrect column '$sColName' (".CMDBSource::GetFieldSpec($sTable,
	$sColName).' instead of '.$sColumnDef."), in the table '$sTable' for the data synchro task ".$this->GetName().' ('.$this->GetKey()."). The column '$sColName' will be re-created.\n";
	}
	}

iTop/synchro/synchrodatasource.class.inc.php

Lines 1154 to 1155 in 4c626d0

	if (CMDBSource::IsField($sTable, $sAttCode)) {
	$aRepairQueries[] = "ALTER TABLE `$sTable` CHANGE `$sAttCode` `$sAttCode` $sColumnDef";

And also for 2.7:

iTop/synchro/synchrodatasource.class.inc.php

Lines 1146 to 1161 in 4e95ca3

	elseif (strcasecmp(CMDBSource::GetFieldType($sTable, $sColName), $sColumnDef) != 0)
	{
	$bFixNeeded = true;
	$bOneColIsMissing = true;
	if (count($aColumns) > 1)
	{
	echo "Incorrect column '$sColName' (".CMDBSource::GetFieldType($sTable,
	$sColName).' instead of '.$sColumnDef."), in the table '$sTable' for the data synchro task ".$this->GetName().' ('.$this->GetKey()."). The columns '".implode("', '",
	$aColumns)." will be re-created.'.\n";
	}
	else
	{
	echo "Incorrect column '$sColName' (".CMDBSource::GetFieldType($sTable,
	$sColName).' instead of '.$sColumnDef."), in the table '$sTable' for the data synchro task ".$this->GetName().' ('.$this->GetKey()."). The column '$sColName' will be added.\n";
	}
	}

iTop/synchro/synchrodatasource.class.inc.php

Lines 1206 to 1209 in 4e95ca3

	if (CMDBSource::IsField($sTable, $sAttCode))
	{
	$aRepairQueries[] = "ALTER TABLE `$sTable` CHANGE `$sAttCode` `$sAttCode` $sColumnDef";
	}

[Hipska]

@piRGoif ?

[Hipska]

@piRGoif any feedback?

Also, what is the pending contributor update you are awaiting from me?

[Hipska]

@piRGoif?

[piRGoif]

Hello,
Sorry with the work on the 3.1 release I had very little time. Will try to get back to this PR during upcoming weeks.

[Hipska]

Hello @piRGoif do you have any update for me please?

What update do you expect from me?

[Hipska]

@piRGoif ?

[piRGoif]

Hello,
Sorry no possibility for me to handle this PR. Setting it back in the backlog.

[Molkobain]

Functional review:

• A workaround exists: synchronize the linkset table directly, but it's not a friendly solution
• Ensure that there will be no performance issue during migration (Guillaume)
• Ensure that DS tables are rebuilt during the setup (Guillaume) so the format of the column changes

[Hipska]

@Molkobain when will the technical review happen? I see the PR is still on "pending functional review" on the dashboard..