AddressSanitizer: memcmp issue #9022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/usr/bin/coolforkit memcmp asan/../sanitizer_common/sanitizer_common_interceptors.inc:875 (discriminator 9) /usr/bin/coolforkit (anonymous namespace)::textItem(std::vector<char, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool&) online/kit/KitQueue.cpp:52 /usr/bin/coolforkit KitQueue::put(std::vector<char, std::allocator<char> > const&) online/kit/KitQueue.cpp:94 since: commit f8a0d6c Date: Thu May 9 15:29:49 2024 +0100 Callbacks: minor efficiency wins, avoid tokenizing where we can. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ie5d0f86bb33c810b6a5f177421485c977b7fc79a
vmiklos
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin/coolforkit
memcmp
asan/../sanitizer_common/sanitizer_common_interceptors.inc:875 (discriminator 9)
/usr/bin/coolforkit
(anonymous namespace)::textItem(std::vector<char, std::allocator > const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, bool&)
online/kit/KitQueue.cpp:52
/usr/bin/coolforkit
KitQueue::put(std::vector<char, std::allocator > const&)
online/kit/KitQueue.cpp:94
since:
commit f8a0d6c
Date: Thu May 9 15:29:49 2024 +0100
Change-Id: Ie5d0f86bb33c810b6a5f177421485c977b7fc79a
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay