Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Update extern codis-server(redis-server) to version 5.0.8 #1706

Open
wants to merge 2 commits into
base: release3.2
Choose a base branch
from

Conversation

Icemap
Copy link

@Icemap Icemap commented Apr 5, 2020

  • Updated codis-server to redis version 5.0.8
  • Tested all codis command by manual work .( ToT )
  • Passed command: make gotest

PTAL.

@Icemap
Copy link
Author

Icemap commented Apr 7, 2020

@spinlock
PTAL.
Redis 3.2.x version in some situation could be make a lots memory fragmentation.
Only can restart service to remove it.

@Icemap
Copy link
Author

Icemap commented Apr 7, 2020

Fixed a memory leak error in async mode.

@spinlock
Copy link
Member

这个 PR 太大了。我们可能开一个新的 branch 来一点点的 merge 么?

@spinlock
Copy link
Member

PS, memory leak 的点是在哪里?

@Icemap
Copy link
Author

Icemap commented Sep 29, 2020

是这样,这个PR存在两次提交。
第一次,是将codis-server升级到基于redis-5.0.8版本,背景是因为3.2.x中内存碎片在运行时无法回收,只能重启后回收的问题,而5.0.8没有该问题,所以可升级解决,就有了第一次提交。
第二次,是我们在集群中测试,发现了内存泄漏,导致的原因是因为5.0.8与3.2.x的存储KV结构体不同。而在异步模式中使用万能指针,编译通过,但在异步模式中运行时异常,之前开启的异步结构体指针成为野指针。这个在第二次提交中已经修复。其实就是把结构体改对了而已。

@Pangdeijiang
Copy link

您好! 我想pull基于redis-5.0.8 server版本的codis,但是现在官方没有合并好像下载不下来,请问怎么能获取到呢

@Icemap
Copy link
Author

Icemap commented Jan 21, 2021

您好! 我想pull基于redis-5.0.8 server版本的codis,但是现在官方没有合并好像下载不下来,请问怎么能获取到呢

我的分支在Fork的仓库中存放,地址为:https://github.com/Icemap/codis/commits/release3.2-redis-5.0.8
官方这里是未合并的,因为源码引入的缘故,升级到5.0.8的PR太大了,这是一个风险点。
您可以尝试使用一下,若使用出现任何问题,或者使用正常的话,都希望能在此给出反馈。
我可以在此处修复,或佐证此PR验证正常,可增加官方合并的机率。
@Pangdeijiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants