Change cookies_alert to cookies_consent (#5)

* Change cookies_alert to cookies_consent * CR fixes * CR and version fixes
CodiTramuntana · Jan 23, 2024 · 9378c08 · 9378c08
1 parent 790ef85
commit 9378c08
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## Version 1.0.0
+- Breaking change: cookies_alert is now cookies_consent
+- cookies_consent is now a Boolean instead of defined/undefined
+
 ## Version 0.2.1
 - Fix Deny button
 

diff --git a/app/assets/javascripts/cookiesalert/cookies_alert.js b/app/assets/javascripts/cookiesalert/cookies_alert.js
@@ -9,30 +9,30 @@ var cookies = {
       cookies.btn = obj.btn || cookies.btn
       cookies.expires = obj.expires || cookies.expires
     }
- 
-    if (Cookies.get('cookies_alert') === undefined) {
+
+    if (Cookies.get('cookies_consent') === undefined) {
       $(cookies.div).css({ visibility : 'visible' })
       $(cookies.btn).click(function () {
-        cookies.accept();
-        setNonTechnicalCookies();
+        cookies.accept_all_cookies();
       })
       $(cookies.denyBtn).click(function () {
-        cookies.remove();
-        $(cookies.div).css({ visibility : 'visible' });
+        cookies.only_technical_cookies();
+        $(cookies.div).css({ visibility : 'hidden' });
       })
     } else {
       $(cookies.denyBtn).click(function () {
-        cookies.remove();
+        cookies.only_technical_cookies();
         $(cookies.div).css({ visibility : 'hidden' });
       })
     }
   },
-  accept : function () {
-    Cookies.set('cookies_alert','true', { expires : cookies.expires });
-    $(cookies.div).css({ visibility : 'hidden' })
+  accept_all_cookies : function () {
+    Cookies.set('cookies_consent', 'true', { expires : cookies.expires });
+    $(cookies.div).css({ visibility : 'hidden' });
+    setNonTechnicalCookies();
   },
-  remove : function () {
-    Cookies.remove('cookies_alert');
+  only_technical_cookies : function () {
+    Cookies.set('cookies_consent', 'false');
   }
 }
 

diff --git a/lib/cookiesalert/version.rb b/lib/cookiesalert/version.rb
@@ -1,3 +1,3 @@
 module Cookiesalert
-  VERSION = "0.2.1"
+  VERSION = "1.0.0"
 end