Shrinker.check_history now returns only the used portion of the history

CoderDennis · Feb 5, 2024 · d49f603 · d49f603
1 parent d2a041d
commit d49f603
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/NOTES.md b/NOTES.md
@@ -94,7 +94,9 @@ Copy more of the elm-test implementation. Create a `Shrinker` module.
 
 - [ ] Add configuration option for how many times to run the test body.
 
-- [ ] Only feed used history into next round of shrinking? Discard unused values at the end of history.
+- [x] Only feed used history into next round of shrinking? Discard unused values at the end of history.
+Currently, this doesn't work with the implementation of binary search, but it does work for the shrinking
+by chunks.
 
 - [ ] Implement other basic generators such as `atom`, `binary`, `string`, etc.
 

diff --git a/lib/decorum/shrinker.ex b/lib/decorum/shrinker.ex
@@ -153,11 +153,11 @@ defmodule Decorum.Shrinker do
     prng = Prng.hardcoded(history)
 
     try do
-      {value, _} = generator.(prng)
+      {value, prng} = generator.(prng)
 
       case check_function.(value) do
         :ok -> :fail
-        {:error, message} -> {:pass, history, value, message}
+        {:error, message} -> {:pass, Prng.get_history(prng), value, message}
       end
     rescue
       Decorum.EmptyHistoryError -> :fail