Refactor stories#sort to be simpler and avoid throwing ActiveRecord::ReadOnlyRecord #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botandrose
force-pushed
the
fix-activerecord-readonly-error
branch
from
34d847d
to
c9e0a11
Compare
botandrose
force-pushed
the
fix-activerecord-readonly-error
branch
from
c9e0a11
to
c3aafa8
Compare
botandrose
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stories in the Current column are reordered, the column can contain accepted stories, which are marked as readonly. Trying to save those results in a
ActiveRecord::ReadOnlyRecord, even though the position column isn't being changed, so just ignore them.