nw6 | nazanin-saedi| BikeForRefugees | [TECH ED] Bikes for Refugees | week1 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-bfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ara225
requested changes
Oct 9, 2023
| @@ -64,14 +64,13 @@ <h1>Bikes for Refugees</h1> | |||
| Providing donated bikes and accessories to refugees and asylum | |||
| seekers in Scotland. | |||
| </p> | |||
| <button>Donate a bike today</button> | |||
| <button>Volunteer</button> | |||
| <button class="donated">Donate a bike today</button> | |||
There was a problem hiding this comment.
Descriptive class names :) You need to style these a bit diffrently though to look like the image but I am sure you are aware of that. Were also need background images
| <img | ||
| class="article__thumbnail" | ||
| src="spring-fundraisers_thumbnail.jpg" | ||
| src="/images/spring-fundraisers_thumbnail.jpg" |
|
|
||
| :root { | ||
| --grey-dark: #292b2c; | ||
| --grey-light: #e4e4e4; |
| /* hero */ | ||
|
|
||
| .hero { | ||
| background-image: url("../images/header-bike.jpg"); |
There was a problem hiding this comment.
I'm afraid this link is broken, it will work in the other CSS file
| /* Alert */ | ||
|
|
||
| .alert { | ||
| background-color: var(--orange-light); |
| @@ -0,0 +1,295 @@ | |||
| /** | |||
| * | |||
There was a problem hiding this comment.
This is the wrong CSS file I'm afraid - the one in syles is the one you want this is why the styles aren't showing up. I think the work you have done is very good though, it's very close
https://github.com/CodeYourFuture/bikes-for-refugees/blob/main/styles/style.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.