Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW6 | Areeb Sattar | HTML-CSS | Week-1 #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

areebsattar
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for cyf-bfr ready!

Name Link
🔨 Latest commit 39a5a4e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-bfr/deploys/650df04e560ecc0008af1cc1
😎 Deploy Preview https://deploy-preview-471--cyf-bfr.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JayMayer
Copy link
Member

JayMayer commented Oct 1, 2023

Great work Areeb! You've successfully completed all the tasks and even the stretch task, and it's clear you understand how to use semantic HTML and CSS styles. I especially like the use of <nav> in your <header> 🥇

My only suggestion is to take the semantic HTML a little bit further. The "Upcoming Events" section suits a <section> containing <article>s as well. And like headers, footers have their own semantic element that is (unsurprisingly) <footer>

Keep up the great work, I look forward to seeing what comes next!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants