-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6-ZelihaPala-Bike-Project-html-week-1 #468
base: main
Are you sure you want to change the base?
NW6-ZelihaPala-Bike-Project-html-week-1 #468
Conversation
✅ Deploy Preview for cyf-bfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
<div> | ||
<ul class="navigation__list"> | ||
<li class="navigation__item"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the colour of the links are meant to become orange on hover, please make that happen
styles/style.css
Outdated
button:hover { | ||
background-color: rgb(55, 178, 235); | ||
} | ||
.orange { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of .orange
can you use a css class name like .btn-orange
do the same for .white
in like 123>
Its a better naming convention
Adjust your PR title to fit the format also |
|
||
<button>Donate Now</button> | ||
|
||
<button>Donate Now</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help. I have reviewed and made corrections to the areas you pointed out. If you find something Idid not do correctly just let me know. Thank you for your time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</h3> | ||
</div> | ||
<div class="sidebar"> | ||
<h2 class="heading-underline">Upcoming events</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind checking the project again please? Thank you!
NW6-Zeliha Pala- Bike project-html-week-1