Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW6-ZelihaPala-Bike-Project-html-week-1 #468

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zelihapala
Copy link

@zelihapala zelihapala commented Sep 20, 2023

NW6-Zeliha Pala- Bike project-html-week-1

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for cyf-bfr ready!

Name Link
🔨 Latest commit 614a376
🔍 Latest deploy log https://app.netlify.com/sites/cyf-bfr/deploys/65157609c3632c00080e289a
😎 Deploy Preview https://deploy-preview-468--cyf-bfr.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


<div>
<ul class="navigation__list">
<li class="navigation__item">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these navigation links all look lumped together, do you think you can add space between them using css?
Screenshot 2023-09-26 at 08 57 50

Check out padding through the MDN docs to have an idea on what to do

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the colour of the links are meant to become orange on hover, please make that happen

styles/style.css Outdated
button:hover {
background-color: rgb(55, 178, 235);
}
.orange {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of .orange can you use a css class name like .btn-orange do the same for .white in like 123>

Its a better naming convention

@bunday
Copy link

bunday commented Sep 26, 2023

Bike project has been done.

Adjust your PR title to fit the format also


<button>Donate Now</button>

<button>Donate Now</button>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on hover of the button, it becomes blue, can you make it orange as required, thanks
Screenshot 2023-09-26 at 09 19 22

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help. I have reviewed and made corrections to the areas you pointed out. If you find something Idid not do correctly just let me know. Thank you for your time

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-27 at 10 12 08

When I hover on this button, the background should be white and the text should be orange, see a picture of what it should look like
Screenshot 2023-09-27 at 10 13 37

@zelihapala zelihapala changed the title Nw6 zeliha bike project-html-week-1 NW6-zelihaPala-Bike- Project-html-week-1 Sep 26, 2023
@zelihapala zelihapala changed the title NW6-zelihaPala-Bike- Project-html-week-1 NW6-zelihaPala-Bike-Project-html-week-1 Sep 26, 2023
@zelihapala zelihapala changed the title NW6-zelihaPala-Bike-Project-html-week-1 NW6-ZelihaPala-Bike-Project-html-week-1 Sep 26, 2023
</h3>
</div>
<div class="sidebar">
<h2 class="heading-underline">Upcoming events</h2>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space before the text, can you remove this? you might need to check on the padding you are using at the moment
Screenshot 2023-09-27 at 10 14 42
Screenshot 2023-09-27 at 10 14 49

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind checking the project again please? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants